Re: [meta-oe][PATCH] gpsd: Don't build without optimization

[Adrian Bunk <bunk@stusta.de>]

On Tue, Jul 09, 2019 at 11:54:19AM -0700, Khem Raj wrote:
> On Tue, Jul 9, 2019 at 10:26 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > The upstream build system adds -O0 when debug is enabled.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > ---
> >  meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > index 6716f402a..43bf25a93 100644
> > --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > @@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
> >  EXTRA_OESCONS = " \
> >      sysroot=${STAGING_DIR_TARGET} \
> >      libQgpsmm='false' \
> > -    debug='true' \
> > -    strip='false' \
> > +    debug='false' \
> > +    nostrip='true' \
> 
> I think this change is improvement over what we have, however it will
> be nicer if it was knobbed with
> DEBUG_BUILD flag, then we can get proper debug info when doing a debug
> build as user will expect.
>...

Sorry for being terse in the description.

For gpsd "debug" means adding -g here, and this is already additionally 
inserted through the normal OE CFLAGS.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed