From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [warrior][PATCH 4/5] oprofile: drop virtual/kernel dependency and switch back to TUNE_PKGARCH
Date: Wed, 10 Jul 2019 10:46:54 +0000 [thread overview]
Message-ID: <20190710104655.2229-4-Martin.Jansa@gmail.com> (raw)
In-Reply-To: <20190710104655.2229-1-Martin.Jansa@gmail.com>
From: Martin Jansa <martin.jansa@gmail.com>
* the kernel dependency was added couple years ago with:
https://git.openembedded.org/openembedded-core/commit/?id=16bc366877a2e02d96adb91b90e30710777e6f09
the reasons for it no longer seem valid as it build ok
without the dependency
* there as some differences in the resulting binaries (built with and without
kernel dependency):
docker-shr qemux86-64@ ~/build/oe-core $ diff -rq tmp-glibc/work/*/oprofile/*/image
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/ocount and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/ocount differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/opannotate and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/opannotate differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/oparchive and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/oparchive differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/operf and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/operf differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/opgprof and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/opgprof differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/ophelp and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/ophelp differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/opimport and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/opimport differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/opreport and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/opreport differ
* comparing the first one with diffoscope shows only 2 insignificant changes:
- GNU 0x00000014 NT_GNU_BUILD_ID (unique build ID bitstring) Build ID: 71d68718f2b1393cce55605691453ca0615a985d
+ GNU 0x00000014 NT_GNU_BUILD_ID (unique build ID bitstring) Build ID: 3b6d2e8b3ce02b99a41e594fafb756e5648edd3c
- 0x0041ab00 31203230 31390032 323a3334 3a333100 1 2019.22:34:31.
+ 0x0041ab00 31203230 31390032 323a3239 3a303600 1 2019.22:29:06.
* similarly for other binaries
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb | 4 ----
1 file changed, 4 deletions(-)
diff --git a/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb b/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb
index 8d706e4a50..4e5b6ca33c 100644
--- a/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb
+++ b/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb
@@ -1,11 +1,7 @@
require oprofile.inc
-DEPENDS += "virtual/kernel"
DEPENDS_append_powerpc64 = " libpfm4"
-# Depends on MACHINE_ARCH kernel
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
SRC_URI[md5sum] = "bd998df5521ebedae31e71cd3fb6200b"
SRC_URI[sha256sum] = "95ded8bde1ec39922f0af015981a67aec63e025a501e4dc04cd65d38f73647e6"
--
2.17.1
next prev parent reply other threads:[~2019-07-10 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 10:46 [warrior][PATCH 1/5] ndctl: make MACHINE_ARCH and ignore from libblockdev Martin Jansa
2019-07-10 10:46 ` [warrior][PATCH 2/5] ndctl: Remove the unnecessary dependency on virtual/kernel Martin Jansa
2019-07-10 10:46 ` [warrior][PATCH 3/5] oprofile: make MACHINE_ARCH Martin Jansa
2019-07-10 10:46 ` Martin Jansa [this message]
2019-07-10 10:46 ` [warrior][PATCH 5/5] SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS add lsb, busybox and util-linux for phoronix-test-suite Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710104655.2229-4-Martin.Jansa@gmail.com \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox