From: Adrian Bunk <bunk@stusta.de>
To: Armin Kuster <akuster808@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [warrior 04/23] network-manager-applet: Remove obsolete dbus-glib and libnm-glib dependencies
Date: Sun, 1 Sep 2019 09:39:54 +0300 [thread overview]
Message-ID: <20190901063954.GB22307@localhost> (raw)
In-Reply-To: <c9e4dfbcc163fdc33f62419b5c65c057c924247d.1567286967.git.akuster808@gmail.com>
On Sat, Aug 31, 2019 at 02:31:25PM -0700, Armin Kuster wrote:
> From: Adrian Bunk <bunk@stusta.de>
>
> network-manager-applet stopped using dbus-glib 3 years ago.
>
> Building of the obsolete libnm-gtk is disabled by default in 1.8.20.
>...
This commit is not really appropriate for stable branches.
> --- a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.20.bb
> +++ b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.20.bb
> @@ -2,7 +2,7 @@ SUMMARY = "GTK+ applet for NetworkManager"
> LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
>
> -DEPENDS = "gtk+3 libnotify libsecret networkmanager dbus-glib \
> +DEPENDS = "gtk+3 libnotify libsecret networkmanager \
>...
That's a cleanup change removing an unused build dependency with
no (intentional) changes to the built binaries.
> --- a/meta-gnome/recipes-connectivity/networkmanager/networkmanager_%.bbappend
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# networkmanager-applet requires glib support
> -PACKAGECONFIG_append = " glib"
>...
The bbappend might not be nice, but removing it would be a behaviour
change in a stable branch.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-09-01 6:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 21:31 [warrior 00/23] Patch Review Armin Kuster
2019-08-31 21:31 ` [warrior 01/23] openh264: Fix armv7ve build Armin Kuster
2019-08-31 21:31 ` [warrior 02/23] fuse: upgrade 2.9.8 -> 2.9.9 Armin Kuster
2019-08-31 21:31 ` [warrior 03/23] mariadb: Upgrade to 10.3.16 Armin Kuster
2019-08-31 21:31 ` [warrior 04/23] network-manager-applet: Remove obsolete dbus-glib and libnm-glib dependencies Armin Kuster
2019-09-01 6:39 ` Adrian Bunk [this message]
2019-09-03 2:41 ` akuster808
2019-08-31 21:31 ` [warrior 05/23] volume-key: fix "Nothing RPROVIDES" when multilib enabled Armin Kuster
2019-08-31 21:31 ` [warrior 06/23] isomd5sum: " Armin Kuster
2019-08-31 21:31 ` [warrior 07/23] satyr: " Armin Kuster
2019-08-31 21:31 ` [warrior 08/23] fuse-exfat: moved to github Armin Kuster
2019-08-31 21:31 ` [warrior 09/23] exfat-utils: " Armin Kuster
2019-08-31 21:31 ` [warrior 10/23] openvpn: respect pid file in init.d service start Armin Kuster
2019-08-31 21:31 ` [warrior 11/23] net-snmp: update SRC_URI Armin Kuster
2019-08-31 21:31 ` [warrior 12/23] redis: backport a fix for stack trace generation on aarch64 Armin Kuster
2019-08-31 21:31 ` [warrior 13/23] ntop: fix missing return from non-void function Armin Kuster
2019-08-31 21:31 ` [warrior 14/23] libopus: Limit forcing ARM mode ISA to v5 only Armin Kuster
2019-09-01 6:32 ` Adrian Bunk
2019-09-03 2:41 ` akuster808
2019-08-31 21:31 ` [warrior 15/23] freeradius: add runtime dependency on perl Armin Kuster
2019-08-31 21:31 ` [warrior 16/23] scsirastools: add runtime dependency on bash Armin Kuster
2019-08-31 21:31 ` [warrior 17/23] scsirastools: add runtime dependency on bash II Armin Kuster
2019-08-31 21:31 ` [warrior 18/23] zeromq: Upgrade 4.3.1 -> 4.3.2 Armin Kuster
2019-08-31 21:31 ` [warrior 19/23] gnome-desktop3: Fix REQUIRED_DISTRO_FEATURES Armin Kuster
2019-08-31 21:31 ` [warrior 20/23] wireshark: Use an upstream URL that stays valid longer Armin Kuster
2019-08-31 21:31 ` [warrior 21/23] libgit2: Upgrade 0.27.8 -> 0.27.9 Armin Kuster
2019-08-31 21:31 ` [warrior 22/23] vlc: notify switched to GTK+3 some time ago Armin Kuster
2019-08-31 21:31 ` [warrior 23/23] apache2: upgrade 2.4.39 -> 2.4.41 Armin Kuster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190901063954.GB22307@localhost \
--to=bunk@stusta.de \
--cc=akuster808@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox