Re: [meta-oe] [PATCH] renderdoc: add x11 to REQUIRED_DISTRO_FEATURES

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]

On Fri, Oct 04, 2019 at 01:08:35PM +0300, Adrian Ratiu wrote:
> This recipe depends on having x11 enabled so we add it to fix:
> 
> ERROR: Nothing PROVIDES 'libxcb' (but
> meta-oe/meta-oe/recipes-graphics/renderdoc/renderdoc_1.4.bb
> DEPENDS on or otherwise requires it)
> libxcb was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)

Thanks for quick update!

Sorry I haven't mentioned it in the (late) review comment, but this will
also need distro_features_check in the inherit for
REQUIRED_DISTRO_FEATURES variable to work.

Cheers,

> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
> ---
>  meta-oe/recipes-graphics/renderdoc/renderdoc_1.4.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-oe/recipes-graphics/renderdoc/renderdoc_1.4.bb b/meta-oe/recipes-graphics/renderdoc/renderdoc_1.4.bb
> index b6e0c92f6..dd5e4058c 100644
> --- a/meta-oe/recipes-graphics/renderdoc/renderdoc_1.4.bb
> +++ b/meta-oe/recipes-graphics/renderdoc/renderdoc_1.4.bb
> @@ -10,6 +10,8 @@ SRC_URI = "git://github.com/baldurk/${BPN}.git;protocol=http;branch=v1.x \
>  "
>  S = "${WORKDIR}/git"
>  
> +REQUIRED_DISTRO_FEATURES = "x11"
> +
>  DEPENDS += "virtual/libx11 virtual/libgl libxcb xcb-util-keysyms vim-native"
>  
>  RDEPENDS_${PN} = "libxcb xcb-util-keysyms"
> -- 
> 2.23.0
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]