Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: max.oss.09@gmail.com
To: openembedded-devel@lists.openembedded.org
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Max Krummenacher <max.krummenacher@toradex.com>
Subject: [meta-oe][PATCH] libgpiod_2.2: depend on glib-2.0
Date: Mon, 28 Oct 2024 12:24:50 +0100	[thread overview]
Message-ID: <20241028112450.2793248-1-max.oss.09@gmail.com> (raw)

From: Max Krummenacher <max.krummenacher@toradex.com>

In my setup a build fails with

| checking for gobject-introspection... configure: error: gobject-introspection-1.0 is not installed
| NOTE: The following config.log files may provide further information.
| NOTE: /var/home/krm/build/oe-core_master/build/tmp/work/cortexa55-tdx-linux/libgpiod/2.2/build/config.log
| ERROR: configure failed

From config.log this seems to be related to glib-2.0 not found:

| configure:22484: $PKG_CONFIG --exists --print-errors "gobject-introspection-1.0"
| Package glib-2.0 was not found in the pkg-config search path.
| Perhaps you should add the directory containing `glib-2.0.pc'
| to the PKG_CONFIG_PATH environment variable
| Package 'glib-2.0', required by 'gobject-introspection-1.0', not found
| configure:22487: $? = 1
| configure:22491: error: gobject-introspection-1.0 is not installed

Note that glib-2.0.pc is present in recipes-sysroot-native but not
in recipes-sysroot.

Adding glib-2.0 to depends allows successful build of libgpiod 2.

Fixes: 117d09ce43c7 ("libgpiod: update to v2.2")
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
 meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb | 2 ++
 1 file changed, 2 insertions(+)

I'm unsure if that is the correct fix.
I would have expected that if gobject-introspection-1.0.pc depends
on glib-2.0 to be present, then the inherit of gobject-introspection
would have done the needful.
However I'm not really familiar with gobject-introspection in the
first place.

Max

diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb
index b55da72f7b7f..3d9758e27af7 100644
--- a/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb
+++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb
@@ -9,6 +9,8 @@ LIC_FILES_CHKSUM = " \
     file://LICENSES/CC-BY-SA-4.0.txt;md5=fba3b94d88bfb9b81369b869a1e9a20f \
 "
 
+DEPENDS += "glib-2.0"
+
 FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}-2.x:"
 
 SRC_URI += "file://gpio-manager.init"
-- 
2.42.0



             reply	other threads:[~2024-10-28 11:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 11:24 max.oss.09 [this message]
2024-10-28 19:21 ` [oe] [meta-oe][PATCH] libgpiod_2.2: depend on glib-2.0 Bartosz Golaszewski
2024-10-30  1:31   ` Khem Raj
2024-10-30  1:33     ` Khem Raj
2024-10-30  9:28       ` Max Krummenacher
2024-10-30 16:35       ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028112450.2793248-1-max.oss.09@gmail.com \
    --to=max.oss.09@gmail.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=max.krummenacher@toradex.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox