From: Armin Kuster <akuster808@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: "J. S." <schonm@gmail.com>, Khem Raj <raj.khem@gmail.com>
Subject: [meta-oe][styhead][PATCH 85/90] nodejs: cleanup
Date: Tue, 5 Nov 2024 09:35:50 -0500 [thread overview]
Message-ID: <20241105143638.2301245-86-akuster808@gmail.com> (raw)
In-Reply-To: <20241105143638.2301245-1-akuster808@gmail.com>
From: "J. S." <schonm@gmail.com>
Drop two patches which haven't been referenced by the nodejs recipe since the
20.11.0 version checkin.
0001-build-fix-build-with-Python-3.12.patch
0001-gyp-resolve-python-3.12-issues.patch
Signed-off-by: Jason Schonberg <schonm@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 2698039ac432d861465b84fc650fcaa8526c8a3c)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
...001-build-fix-build-with-Python-3.12.patch | 55 ----------------
.../0001-gyp-resolve-python-3.12-issues.patch | 63 -------------------
2 files changed, 118 deletions(-)
delete mode 100644 meta-oe/recipes-devtools/nodejs/nodejs/0001-build-fix-build-with-Python-3.12.patch
delete mode 100644 meta-oe/recipes-devtools/nodejs/nodejs/0001-gyp-resolve-python-3.12-issues.patch
diff --git a/meta-oe/recipes-devtools/nodejs/nodejs/0001-build-fix-build-with-Python-3.12.patch b/meta-oe/recipes-devtools/nodejs/nodejs/0001-build-fix-build-with-Python-3.12.patch
deleted file mode 100644
index 39026d0742..0000000000
--- a/meta-oe/recipes-devtools/nodejs/nodejs/0001-build-fix-build-with-Python-3.12.patch
+++ /dev/null
@@ -1,55 +0,0 @@
-From 656f6c91f1da7f1e1ffb01e2de7d9026a84958b5 Mon Sep 17 00:00:00 2001
-From: Luigi Pinca <luigipinca@gmail.com>
-Date: Wed, 8 Nov 2023 21:20:53 +0100
-Subject: [PATCH] build: fix build with Python 3.12
-
-Replace `distutils.version.StrictVersion` with
-`packaging.version.Version`.
-
-Refs: https://github.com/nodejs/node/pull/50209#issuecomment-1795852539
-PR-URL: https://github.com/nodejs/node/pull/50582
-Reviewed-By: Richard Lau <rlau@redhat.com>
-Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
-
-Upstream-Status: Backport [https://github.com/nodejs/node/commit/95534ad82f4e33f53fd50efe633d43f8da70cba6]
-Signed-off-by: Alexander Kanavin <alex@linutronix.de>
----
- configure.py | 11 +++++------
- 1 file changed, 5 insertions(+), 6 deletions(-)
-
-diff --git a/configure.py b/configure.py
-index 62f041ce..18fe7c14 100755
---- a/configure.py
-+++ b/configure.py
-@@ -14,8 +14,6 @@ import bz2
- import io
- from pathlib import Path
-
--from distutils.version import StrictVersion
--
- # If not run from node/, cd to node/.
- os.chdir(Path(__file__).parent)
-
-@@ -30,6 +28,7 @@ tools_path = Path('tools')
-
- sys.path.insert(0, str(tools_path / 'gyp' / 'pylib'))
- from gyp.common import GetFlavor
-+from packaging.version import Version
-
- # imports in tools/configure.d
- sys.path.insert(0, str(tools_path / 'configure.d'))
-@@ -1565,10 +1564,10 @@ def configure_openssl(o):
- # supported asm compiler for AVX2. See https://github.com/openssl/openssl/
- # blob/OpenSSL_1_1_0-stable/crypto/modes/asm/aesni-gcm-x86_64.pl#L52-L69
- openssl110_asm_supported = \
-- ('gas_version' in variables and StrictVersion(variables['gas_version']) >= StrictVersion('2.23')) or \
-- ('xcode_version' in variables and StrictVersion(variables['xcode_version']) >= StrictVersion('5.0')) or \
-- ('llvm_version' in variables and StrictVersion(variables['llvm_version']) >= StrictVersion('3.3')) or \
-- ('nasm_version' in variables and StrictVersion(variables['nasm_version']) >= StrictVersion('2.10'))
-+ ('gas_version' in variables and Version(variables['gas_version']) >= Version('2.23')) or \
-+ ('xcode_version' in variables and Version(variables['xcode_version']) >= Version('5.0')) or \
-+ ('llvm_version' in variables and Version(variables['llvm_version']) >= Version('3.3')) or \
-+ ('nasm_version' in variables and Version(variables['nasm_version']) >= Version('2.10'))
-
- if is_x86 and not openssl110_asm_supported:
- error('''Did not find a new enough assembler, install one or build with
diff --git a/meta-oe/recipes-devtools/nodejs/nodejs/0001-gyp-resolve-python-3.12-issues.patch b/meta-oe/recipes-devtools/nodejs/nodejs/0001-gyp-resolve-python-3.12-issues.patch
deleted file mode 100644
index 9d878dfb8d..0000000000
--- a/meta-oe/recipes-devtools/nodejs/nodejs/0001-gyp-resolve-python-3.12-issues.patch
+++ /dev/null
@@ -1,63 +0,0 @@
-From bf8c96ba6936050ed4a0de5bc8aeeaf2b3c50dc1 Mon Sep 17 00:00:00 2001
-From: Alexander Kanavin <alex@linutronix.de>
-Date: Thu, 7 Dec 2023 12:54:30 +0100
-Subject: [PATCH] gyp: resolve python 3.12 issues
-
-Upstream has updated gyp wholesale in the main branch, so
-this patch can be dropped in due time.
-
-Upstream-Status: Inappropriate [issue will be fixed upstream with the next nodejs LTS update]
-
-Signed-off-by: Alexander Kanavin <alex@linutronix.de>
----
- deps/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py | 4 ++--
- tools/gyp/pylib/gyp/input.py | 4 ++--
- 2 files changed, 4 insertions(+), 4 deletions(-)
-
-diff --git a/deps/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py b/deps/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py
-index d9699a0a..173e9465 100644
---- a/deps/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py
-+++ b/deps/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py
-@@ -16,7 +16,7 @@ import subprocess
- import sys
- import threading
- import traceback
--from distutils.version import StrictVersion
-+from packaging.version import Version
- from gyp.common import GypError
- from gyp.common import OrderedSet
-
-@@ -1183,7 +1183,7 @@ def EvalSingleCondition(cond_expr, true_dict, false_dict, phase, variables, buil
- else:
- ast_code = compile(cond_expr_expanded, "<string>", "eval")
- cached_conditions_asts[cond_expr_expanded] = ast_code
-- env = {"__builtins__": {}, "v": StrictVersion}
-+ env = {"__builtins__": {}, "v": Version}
- if eval(ast_code, env, variables):
- return true_dict
- return false_dict
-diff --git a/tools/gyp/pylib/gyp/input.py b/tools/gyp/pylib/gyp/input.py
-index 354958bf..ab6112e5 100644
---- a/tools/gyp/pylib/gyp/input.py
-+++ b/tools/gyp/pylib/gyp/input.py
-@@ -16,7 +16,7 @@ import subprocess
- import sys
- import threading
- import traceback
--from distutils.version import StrictVersion
-+from packaging.version import Version
- from gyp.common import GypError
- from gyp.common import OrderedSet
-
-@@ -1190,7 +1190,7 @@ def EvalSingleCondition(cond_expr, true_dict, false_dict, phase, variables, buil
- else:
- ast_code = compile(cond_expr_expanded, "<string>", "eval")
- cached_conditions_asts[cond_expr_expanded] = ast_code
-- env = {"__builtins__": {}, "v": StrictVersion}
-+ env = {"__builtins__": {}, "v": Version}
- if eval(ast_code, env, variables):
- return true_dict
- return false_dict
---
-2.39.2
-
--
2.43.0
next prev parent reply other threads:[~2024-11-05 14:37 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 14:34 [meta-oe][styhead][PATCH 00/90] Patch review Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 01/90] bdwgc: upgrade 8.2.6 -> 8.2.8 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 02/90] ctags: upgrade 6.1.20240908.0 -> 6.1.20240915.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 03/90] gnome-backgrounds: upgrade 46.0 -> 47.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 04/90] gnome-chess: " Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 05/90] gnome-font-viewer: " Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 06/90] libmanette: upgrade 0.2.7 -> 0.2.9 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 07/90] pegtl: upgrade 3.2.7 -> 3.2.8 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 08/90] python3-elementpath: upgrade 4.4.0 -> 4.5.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 09/90] python3-eventlet: upgrade 0.36.1 -> 0.37.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 10/90] python3-filelock: upgrade 3.16.0 -> 3.16.1 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 11/90] python3-greenlet: upgrade 3.0.3 -> 3.1.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 12/90] python3-nmap: upgrade 1.6.0 -> 1.9.1 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 13/90] python3-paramiko: upgrade 3.4.1 -> 3.5.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 14/90] python3-platformdirs: upgrade 4.3.1 -> 4.3.6 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 15/90] python3-psycopg: upgrade 3.2.1 -> 3.2.2 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 16/90] python3-pyasn1-modules: upgrade 0.4.0 -> 0.4.1 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 17/90] python3-pymisp: upgrade 2.4.197 -> 2.4.198 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 18/90] python3-pyproject-api: upgrade 1.7.1 -> 1.7.2 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 19/90] python3-pyunormalize: upgrade 15.1.0 -> 16.0.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 20/90] python3-regex: upgrade 2024.7.24 -> 2024.9.11 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 21/90] python3-rich: upgrade 13.8.0 -> 13.8.1 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 22/90] python3-robotframework: upgrade 7.0.1 -> 7.1 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 23/90] python3-virtualenv: upgrade 20.26.4 -> 20.26.5 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 24/90] python3-xmlschema: upgrade 3.3.2 -> 3.4.1 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 25/90] python3-yarl: upgrade 1.10.0 -> 1.11.1 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 26/90] stunnel: upgrade 5.72 -> 5.73 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 27/90] tecla: upgrade 46.0 -> 47.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 28/90] traceroute: upgrade 2.1.5 -> 2.1.6 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 29/90] opencv: upgrade 4.9.0 -> 4.10.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 30/90] abseil-cpp: upgrade 20240116.2 -> 20240722.0 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 31/90] protobuf: add abseil-cpp to RDEPENDS Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 32/90] protobuf: upgrade 4.25.4 -> 4.25.5 Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 33/90] non-repro-meta-networking: update known non-reproducible list Armin Kuster
2024-11-05 14:34 ` [meta-oe][styhead][PATCH 34/90] lksctp-tools: upgrade 1.0.19 -> 1.0.20 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 35/90] gnome-shell: add gnome-control-center dependency Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 36/90] gnome-desktop: update 44.0 -> 44.1 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 37/90] gpsd: make the meta-python dependency conditionally Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 38/90] tcpslice: upgrade 1.7 -> 1.8 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 39/90] audit: Fix CVE_PRODUCT Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 40/90] python3-typer: Disable test_rich_markup_mode tests Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 41/90] perfetto: upgrade 31.0 -> 47.0 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 42/90] python3-pydbus: Add missing rdep on xml module for ptests Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 43/90] python3-ujson: Add python misc modules to ptest rdeps Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 44/90] python3-gunicorn: Add missing rdeps for ptests Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 45/90] python3-eth-hash: Add packageconfigs and switch to pep517-backend Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 46/90] python3-validators: Add missing rdeps for ptests Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 47/90] syslog-ng: upgrade 4.6.0 -> 4.7.0 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 48/90] polkit: Update Upstream-Status of a merged patch Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 49/90] capnproto: Add "capnp" to CVE_PRODUCT Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 50/90] fuse: Add "fuse:fuse" " Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 51/90] python3-pint: Upgrade to 0.24.3 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 52/90] python3-pytest-mock: Fix ptests Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 53/90] python3-sqlparse: Add missing rdep on mypy module for ptests Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 54/90] Revert "gpsd: make the meta-python dependency conditionally" Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 55/90] gpsd: condition the runtime dependence of pyserial on the pygps Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 56/90] xfce4-panel: upgrade 4.18.3 -> 4.18.4 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 57/90] softhsm: add destroyed global access prevention patch Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 58/90] audit: fix build when systemd is enabled Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 59/90] python3-sqlalchemy: Upgrade 2.0.32 -> 2.0.35 and switch to PEP-517 build backend Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 60/90] python3-alembic: " Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 61/90] python3-inflate64: " Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 62/90] python3-spidev: " Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 63/90] python3-pastedeploy: " Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 64/90] python3-reedsolo: " Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 65/90] libtar: patch CVEs Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 66/90] curlpp: Fix build issue Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 67/90] libhugetlbfs: upgrade 2.23 -> 2.24 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 68/90] libhugetlbfs: Use linker wrapper during build Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 69/90] libhugetlbfs: Fix contains reference to TMPDIR [buildpaths] error Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 70/90] wireshark: fix typo in PACKAGECONFIG[zstd] Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 71/90] webkitgtk3: Always use -g1 for debug flags Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 72/90] webkitgtk3: Fix build break with latest gir Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 73/90] nodejs: upgrade 20.17.0 -> 20.18.0 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 74/90] xfce4-panel: upgrade 4.18.4 -> 4.18.5 Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 75/90] apache2: do not depend on zlib header and libs from host Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 76/90] wtmpdb: fix installed-vs-shipped build error Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 77/90] jansson: add JSON_INTEGER_IS_LONG_LONG for cmake Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 78/90] ndisc6: Fix reproducible build Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 79/90] cryptsetup: fix udev PACKAGECONFIG Armin Kuster
2024-11-22 18:57 ` [oe] " Peter Kjellerstedt
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 80/90] sound-theme-freedesktop: Update SRC_URI Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 81/90] rsyslog: Enable 64bit atomics check Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 82/90] minidlna: fix reproducibility Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 83/90] kernel-selftest: Update to allow for turning on all tests Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 84/90] xmlrpc-c: update SRCREV Armin Kuster
2024-11-05 14:35 ` Armin Kuster [this message]
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 86/90] nmap: Fix off-by-one overflow in the IP protocol table Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 87/90] wireguard-tools: fix do_fetch error Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 88/90] vlock: " Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 89/90] xmlsec1: Switch SRC_URI to use github release Armin Kuster
2024-11-05 14:35 ` [meta-oe][styhead][PATCH 90/90] nng: Rename default branch of github.com:nanomsg/nng.git Armin Kuster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105143638.2301245-86-akuster808@gmail.com \
--to=akuster808@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=raj.khem@gmail.com \
--cc=schonm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox