From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com ([143.182.124.21]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SMQlp-00087p-5d for openembedded-devel@lists.openembedded.org; Mon, 23 Apr 2012 23:26:05 +0200 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 23 Apr 2012 14:16:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="92244232" Received: from unknown (HELO helios.localnet) ([10.252.120.17]) by AZSMGA002.ch.intel.com with ESMTP; 23 Apr 2012 14:16:29 -0700 From: Paul Eggleton To: Koen Kooi Date: Mon, 23 Apr 2012 22:16:26 +0100 Message-ID: <2075617.XNr0ya9tIT@helios> Organization: Intel Corporation User-Agent: KMail/4.8.2 (Linux/3.0.0-17-generic-pae; KDE/4.8.2; i686; ; ) In-Reply-To: References: <1335191135-6762-1-git-send-email-koen@dominion.thruhere.net> <2199708.NNXS638hI1@helios> MIME-Version: 1.0 Cc: openembedded-devel@lists.openembedded.org Subject: Re: [meta-kde][PATCH] qt4-x11-free 4.8.0 bbappend: fix GLES configure switch and turn it on for AM335x SoCs as well X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2012 21:26:05 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday 23 April 2012 21:39:36 Koen Kooi wrote: > Op 23-04-12 17:46, Paul Eggleton schreef: > > On Monday 23 April 2012 16:25:35 Koen Kooi wrote: > >> Signed-off-by: Koen Kooi --- > >> recipes-misc-support/qt4-x11-free_4.8.0.bbappend | 5 +++-- 1 files > >> changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/recipes-misc-support/qt4-x11-free_4.8.0.bbappend > >> b/recipes-misc-support/qt4-x11-free_4.8.0.bbappend index > >> b5a3c16..4895893 100644 --- > >> a/recipes-misc-support/qt4-x11-free_4.8.0.bbappend +++ > >> b/recipes-misc-support/qt4-x11-free_4.8.0.bbappend @@ -1,7 +1,8 @@ > >> -QT_GLFLAGS_omap3 = "-egl" +QT_GLFLAGS_omap3 = "-opengl es2 " > >> DEPENDS_append_omap3 = " libgles-omap3" +DEPENDS_append_ti33x = " > >> libgles-omap3" > >> > >> # Needed by kdelibs QT_DISTRO_FLAGS = "-accessibility -sm" > >> > >> -PRINC := "${@int(PRINC) + 1}" \ No newline at end of file +PRINC := > >> "${@int(PRINC) + 2}" > > > > Can we avoid this machine-specific stuff creeping into software layers? > > At least in this case we're appending something in OE-Core so there > > should be no problem with this appearing in an append in the BSP(s). > > Have a look at what was discussed in the "[meta-kde] Test images (was: Re: > [OE-core] RFC: Porting KDE Plasma Active (WIP))" thread Yes, I understand why it was added, but (as I'm sure you're aware) one of the reasons why we did the layer split was to avoid having numbers of machine- specific overrides appearing in generic recipes. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre