From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-opie][PATCH] recipes: Turn ALLOW_EMPTY to be package specific
Date: Wed, 20 Mar 2013 09:25:24 +0000 [thread overview]
Message-ID: <2143718.Cd3otbWQK5@helios> (raw)
In-Reply-To: <1363769996-20782-1-git-send-email-raj.khem@gmail.com>
On Wednesday 20 March 2013 01:59:56 Khem Raj wrote:
> Fixes QA warnings during parse
>
> ERROR: QA Issue:
> /b/kraj/angstrom/sources/meta-opie/recipes-opie/packagegroups/nativesdk-pack
> agegroup-opie-toolchain-host.bb: Variable ALLOW_EMPTY is set as not being
> package specific, please fix this.
> ERROR: QA Issue:
> /b/kraj/angstrom/sources/meta-opie/recipes-opie/packagegroups/packagegroup-o
> pie-toolchain-target.bb: Variable ALLOW_EMPTY is set as not being package
> specific, please fix this.
> ERROR: QA Issue:
> /b/kraj/angstrom/sources/meta-opie/recipes-opie/opie-mediaplayer1/opie-media
> player1_git.bb: Variable ALLOW_EMPTY is set as not being package specific,
> please fix this.
> ERROR: QA Issue:
> /b/kraj/angstrom/sources/meta-opie/recipes-opie/opie-mediaplayer1/opie-media
> player1_1.2.5.bb: Variable ALLOW_EMPTY is set as not being package specific,
> please fix this.
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> recipes-opie/opie-help-en/opie-help-en.inc | 2 +-
> .../opie-mediaplayer1/opie-mediaplayer1.inc | 2 +-
> .../nativesdk-packagegroup-opie-toolchain-host.bb | 2 +-
> .../packagegroup-opie-toolchain-target.bb | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/recipes-opie/opie-help-en/opie-help-en.inc
> b/recipes-opie/opie-help-en/opie-help-en.inc index 30295f3..6c0ae6c 100644
> --- a/recipes-opie/opie-help-en/opie-help-en.inc
> +++ b/recipes-opie/opie-help-en/opie-help-en.inc
> @@ -3,7 +3,7 @@ SECTION = "opie/help"
> LICENSE = "GPLv2"
> # FIXME stopgap until split archives have license files included
> LIC_FILES_CHKSUM =
> "file://${COMMON_LICENSE_DIR}/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
> -ALLOW_EMPTY = "1"
> +ALLOW_EMPTY_${PN} = "1"
> PACKAGE_ARCH = "all"
>
> PACKAGES += "${PN}"
> diff --git a/recipes-opie/opie-mediaplayer1/opie-mediaplayer1.inc
> b/recipes-opie/opie-mediaplayer1/opie-mediaplayer1.inc index
> 22b1069..df35e37 100644
> --- a/recipes-opie/opie-mediaplayer1/opie-mediaplayer1.inc
> +++ b/recipes-opie/opie-mediaplayer1/opie-mediaplayer1.inc
> @@ -2,7 +2,7 @@ DESCRIPTION = "The classic Opie media player
> (core+plugins)." LICENSE = "GPLv2"
> # FIXME stopgap until split archives have license files included
> LIC_FILES_CHKSUM =
> "file://${COMMON_LICENSE_DIR}/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
> -ALLOW_EMPTY = "1"
> +ALLOW_EMPTY_${PN} = "1"
> PACKAGE_ARCH = "all"
> RDEPENDS_${PN} = "opie-mediaplayer1-core"
> RRECOMMENDS_${PN} = "opie-mediaplayer1-libmadplugin
> opie-mediaplayer1-libwavplugin \ diff --git
> a/recipes-opie/packagegroups/nativesdk-packagegroup-opie-toolchain-host.bb
> b/recipes-opie/packagegroups/nativesdk-packagegroup-opie-toolchain-host.bb
> index 52693ba..c97f84a 100644
> ---
> a/recipes-opie/packagegroups/nativesdk-packagegroup-opie-toolchain-host.bb
> +++
> b/recipes-opie/packagegroups/nativesdk-packagegroup-opie-toolchain-host.bb
> @@ -3,6 +3,6 @@ require
> recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb DESCRIPTION =
> "Host packages for Opie SDK"
> PR = "r3"
> LICENSE = "MIT"
> -ALLOW_EMPTY = "1"
> +ALLOW_EMPTY_${PN} = "1"
>
> RDEPENDS_${PN} += "nativesdk-qmake nativesdk-uicmoc"
> diff --git
> a/recipes-opie/packagegroups/packagegroup-opie-toolchain-target.bb
> b/recipes-opie/packagegroups/packagegroup-opie-toolchain-target.bb index
> ca42e0d..04fa21d 100644
> --- a/recipes-opie/packagegroups/packagegroup-opie-toolchain-target.bb
> +++ b/recipes-opie/packagegroups/packagegroup-opie-toolchain-target.bb
> @@ -1,7 +1,7 @@
> DESCRIPTION = "Target packages for Opie SDK"
> PR = "r7"
> LICENSE = "MIT"
> -ALLOW_EMPTY = "1"
> +ALLOW_EMPTY_${PN} = "1"
>
> LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
Merged, thanks!
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
prev parent reply other threads:[~2013-03-20 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 8:59 [meta-opie][PATCH] recipes: Turn ALLOW_EMPTY to be package specific Khem Raj
2013-03-20 9:25 ` Paul Eggleton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2143718.Cd3otbWQK5@helios \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox