Bug in cooker - networked PR_SERV

["Jan-Simon Möller" <dl9pf@gmx.de>]

Hi !

I found a bug in cooker that shows up when I try to enable the networked 
PRSERV. bitbake will crash (and still run at 100% after CTRL-C) until kill -9.

I tracked it down to bitbake/lib/bb/cooker.py line 169:
        if self.state != state.initial:
            raise Exception("Illegal state for feature set change")

self.state seems to be 6 at this stage and state.initial is 0 .

Hack: If I comment out this check, it seems to continue, but I see no size-
increase in the prserv sqlite and also nothing printed for loglevel=DEBUG in 
the log. 


Here are the details:

My setup is:
Build Configuration:
BB_VERSION        = "1.24.0"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "openSUSE-project-13.2"
TARGET_SYS        = "i586-poky-linux"
MACHINE           = "qemux86"
DISTRO            = "poky"
DISTRO_VERSION    = "1.7.1"
TUNE_FEATURES     = "m32 i586"
TARGET_FPU        = ""
meta              
meta-yocto        
meta-yocto-bsp    = "<unknown>:<unknown>"

####### Only changes to conf/local.conf:
PRSERV_HOST="127.0.0.1:5555"
(an a prserv started in a separate terminal)

####### Crash 

x86> bitbake core-image-minimal
Traceback (most recent call last):
  File "/home/dl9pf/test1/script/4.1/poky-dizzy-12.0.1/bitbake/bin/bitbake", 
line 382, in <module>
    ret = main()
  File "/home/dl9pf/test1/script/4.1/poky-dizzy-12.0.1/bitbake/bin/bitbake", 
line 347, in main
    server_connection = server.establishConnection(featureset)
  File "/home/dl9pf/test1/script/4.1/poky-
dizzy-12.0.1/bitbake/lib/bb/server/process.py", line 247, in 
establishConnection
    raise BaseException(error)
BaseException: Traceback (most recent call last):
  File "/home/dl9pf/test1/script/4.1/poky-
dizzy-12.0.1/bitbake/lib/bb/command.py", line 71, in runCommand
    result = command_method(self, commandline)
  File "/home/dl9pf/test1/script/4.1/poky-
dizzy-12.0.1/bitbake/lib/bb/command.py", line 268, in setFeatures
    command.cooker.setFeatures(features)
  File "/home/dl9pf/test1/script/4.1/poky-
dizzy-12.0.1/bitbake/lib/bb/cooker.py", line 169, in setFeatures
    raise Exception("Illegal state for feature set change")
Exception: Illegal state for feature set change

ERROR: Unable to set the cooker to the correct featureset: Traceback (most 
recent call last):
  File "/home/dl9pf/test1/script/4.1/poky-
dizzy-12.0.1/bitbake/lib/bb/command.py", line 71, in runCommand
    result = command_method(self, commandline)
  File "/home/dl9pf/test1/script/4.1/poky-
dizzy-12.0.1/bitbake/lib/bb/command.py", line 268, in setFeatures
    command.cooker.setFeatures(features)
  File "/home/dl9pf/test1/script/4.1/poky-
dizzy-12.0.1/bitbake/lib/bb/cooker.py", line 169, in setFeatures
    raise Exception("Illegal state for feature set change")
Exception: Illegal state for feature set change



Best,
--- 

Dipl.-Ing.
Jan-Simon Möller

jansimon.moeller@gmx.de