From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Yevhen Kyriukha <kirgene@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] udisks: updated to v2.1.1.
Date: Mon, 09 Dec 2013 16:03:49 +0000 [thread overview]
Message-ID: <35556909.VfM2a6CS5T@helios> (raw)
In-Reply-To: <l84o5c$go8$1@ger.gmane.org>
On Monday 09 December 2013 16:38:33 Koen Kooi wrote:
> Yevhen Kyriukha schreef op 09-12-13 15:37:
> > One patch was removed because changes are already exist in upstream
> > version. Added patch to turn libatasmart, polkit, acl and
> > libsystemd-login into optional dependencies.
> >
> > Signed-off-by: Yevhen Kyriukha <kirgene@gmail.com> ---
> >
> > +DESCRIPTION = "A storage daemon that implements well-defined D-Bus
> > interfaces that can be used to query and manipulate storage devices."
> > +LICENSE = "GPLv2+" +LIC_FILES_CHKSUM =
> > "file://COPYING;md5=dd79f6dbbffdbc8e86b086a8f0c0ef43" + +DEPENDS = "udev
> > dbus-glib glib-2.0" + +DEPENDS += "${@base_contains('DISTRO_FEATURES',
> > 'systemd', 'systemd', '', d)}" + +SRC_URI =
> > "http://udisks.freedesktop.org/releases/${P}.tar.bz2 \ +
> > file://optional-depends.patch" + +SRC_URI[md5sum] =
> > "80e03f312542b800cf3162254b202725" +SRC_URI[sha256sum] =
> > "013b09ff38aa256b89c01525771f4565cb088724d5c8c79b32e9f811e88086fb" +
> > +inherit autotools systemd + +PACKAGECONFIG[atasmart] =
> > "--enable-libatasmart,--disable-libatasmart,libatasmart"
> > +PACKAGECONFIG[polkit] = "--enable-polkit,--disable-polkit,polkit"
> > +PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,libacl"
> > +PACKAGECONFIG[systemd-login] =
> > "--enable-libsystemd-login,--disable-libsystemd-login,systemd"
>
> This is missing a default PACKAGECONFIG assignment to enable all that to
> have feature parity with the 1.x version.
Also, please use the -M option to git-send-email so that it's clear as to what
has changed.
Thanks,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
prev parent reply other threads:[~2013-12-09 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 14:37 [meta-oe][PATCH] udisks: updated to v2.1.1 Yevhen Kyriukha
2013-12-09 15:38 ` Koen Kooi
2013-12-09 16:03 ` Paul Eggleton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35556909.VfM2a6CS5T@helios \
--to=paul.eggleton@linux.intel.com \
--cc=kirgene@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox