From: "Trevor Gamblin" <trevor.gamblin@windriver.com>
To: akuster <akuster808@gmail.com>,
openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-python][PATCH 2/4] python3-icu: add new package
Date: Sat, 11 Jul 2020 13:18:45 -0400 [thread overview]
Message-ID: <365c5353-a5eb-9521-e1ce-69615975ee4b@windriver.com> (raw)
In-Reply-To: <20200710040109.22600-3-akuster808@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2879 bytes --]
On 7/10/20 12:01 AM, akuster wrote:
> needed by python3-natsort
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Acked-by: Trevor Gamblin <trevor.gamblin@windriver.com>
> ---
> .../python/python3-icu/fix_host_include.patch | 30 +++++++++++++++++++
> .../python/python3-icu_2.5.bb | 13 ++++++++
> 2 files changed, 43 insertions(+)
> create mode 100644 meta-python/recipes-devtools/python/python3-icu/fix_host_include.patch
> create mode 100644 meta-python/recipes-devtools/python/python3-icu_2.5.bb
>
> diff --git a/meta-python/recipes-devtools/python/python3-icu/fix_host_include.patch b/meta-python/recipes-devtools/python/python3-icu/fix_host_include.patch
> new file mode 100644
> index 0000000000..1b6e890436
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/python3-icu/fix_host_include.patch
> @@ -0,0 +1,30 @@
> +Fixed host contamination of include files
> +
> +python3-icu-2.5-r0 do_package_qa: QA Issue: python3-icu: The compile log indicates that host include and/or library paths were used.
> +
> +Also, don't use icu-config
> +
> +Upstream-Status: [inappropriate] OE specific
> +Signed-off-by: Armin Kuster <akuster808@gmail.com>
> +
> +Index: PyICU-2.5/setup.py
> +===================================================================
> +--- PyICU-2.5.orig/setup.py
> ++++ PyICU-2.5/setup.py
> +@@ -81,7 +81,7 @@ Building PyICU %s for ICU %s (max ICU ma
> +
> + CONFIGURE_WITH_ICU_CONFIG = {
> + 'darwin': True,
> +- 'linux': True,
> ++ 'linux': False,
> + 'freebsd': False, # not tested
> + 'win32': False, # no icu-config
> + 'sunos5': False, # not tested
> +@@ -274,7 +274,6 @@ setup(name="PyICU",
> + ext_modules=[Extension('_icu',
> + [filename for filename in sorted(os.listdir(os.curdir))
> + if filename.endswith('.cpp')],
> +- include_dirs=_includes,
> + extra_compile_args=_cflags,
> + extra_link_args=_lflags,
> + libraries=_libraries)],
> diff --git a/meta-python/recipes-devtools/python/python3-icu_2.5.bb b/meta-python/recipes-devtools/python/python3-icu_2.5.bb
> new file mode 100644
> index 0000000000..5e8c8a3a02
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/python3-icu_2.5.bb
> @@ -0,0 +1,13 @@
> +SUMMARY = "Python extension wrapping the ICU C++ API"
> +SECTION = "devel/python"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=c7c4bfd81a21e3b6368bdcced992bf59"
> +
> +DEPENDS += "pkgconfig icu"
> +
> +PYPI_PACKAGE = "PyICU"
> +SRC_URI[sha256sum] = "a120b68c53f769f37bfb70b7e84ca12c3f4ab1e4df43e87a02dff05ae472cdbc"
> +
> +SRC_URI += "file://fix_host_include.patch"
> +
> +inherit pypi setuptools3
>
>
[-- Attachment #2: Type: text/html, Size: 4223 bytes --]
next prev parent reply other threads:[~2020-07-11 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 4:01 [meta-python][PATCH 0/4] fixed needed for python3-croniter rdep issue akuster
2020-07-10 4:01 ` [meta-python][PATCH 1/4] python3-fastnumbers: Add new package akuster
2020-07-11 17:18 ` [oe] " Trevor Gamblin
2020-07-10 4:01 ` [meta-python][PATCH 2/4] python3-icu: add " akuster
2020-07-11 17:18 ` Trevor Gamblin [this message]
2020-07-10 4:01 ` [meta-python][PATCH 3/4] python3-natsort: " akuster
2020-07-11 17:18 ` [oe] " Trevor Gamblin
2020-07-10 4:01 ` [meta-python][PATCH 4/4] python3-croniter: Fix missing rdep akuster
2020-07-11 17:19 ` [oe] " Trevor Gamblin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365c5353-a5eb-9521-e1ce-69615975ee4b@windriver.com \
--to=trevor.gamblin@windriver.com \
--cc=akuster808@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox