Re: [meta-networking][PATCH] vlan: Add vlan recipe

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Lei,

Some style feedback below.

On Thursday 30 May 2013 11:42:08 lei.yang@windriver.com wrote:
> diff --git a/meta-networking/recipes-support/vlan/vlan_1.9.bb
> b/meta-networking/recipes-support/vlan/vlan_1.9.bb new file mode 100755
> index 0000000..464150c
> --- /dev/null
> +++ b/meta-networking/recipes-support/vlan/vlan_1.9.bb
> @@ -0,0 +1,38 @@
> +DESCRIPTION = "802.1q vlan support program"

Please set SUMMARY instead of DESCRIPTION if you're only setting a short 
description.

> +HOMEPAGE = "http://www.candelatech.com/~greear/"

By the looks of it this should be: 
http://www.candelatech.com/~greear/vlan.html

> +LICENSE         = "GPLv2"
> +SECTION = "console/network"
> +
> +S = "${WORKDIR}/vlan/"
> +
> +SRC_URI = " \
> +	http://www.candelatech.com/~greear/vlan/vlan.${PV}.tar.gz \
> +	file://ip \
> +	file://vlan-pre-up \
> +	file://vlan-post-down \
> +	"
> +
> +CCFLAGS = "-g -D_GNU_SOURCE -Wall -I${STAGING_INCDIR}"
> +LDLIBS = ""
> +
> +do_compile() {
> +	${CC} ${CCFLAGS} -c vconfig.c
> +	${CC} ${CCFLAGS} ${LDFLAGS} -o vconfig vconfig.o ${LDLIBS}
> +}
> +
> +do_install() {
> +	install -d "${D}${sbindir}"
> +	install -m 755 "${S}/vconfig" "${D}${sbindir}/vconfig"
> +	install -d ${D}/${sysconfdir}/network/if-pre-up.d
> +	install -d ${D}/${sysconfdir}/network/if-post-down.d
> +	install -d ${D}/${sysconfdir}/network/if-up.d
> +	install -m 0755 ${WORKDIR}/ip ${D}/${sysconfdir}/network/if-up.d/
> +	install -m 0755 ${WORKDIR}/vlan-pre-up
> ${D}/${sysconfdir}/network/if-pre-up.d/vlan +	install -m 0755
> ${WORKDIR}/vlan-post-down ${D}/${sysconfdir}/network/if-post-down.d/vlan 
> +}
> +
> +
> +SRC_URI[md5sum] = "5f0c6060b33956fb16e11a15467dd394"
> +SRC_URI[sha256sum] =
> "3b8f0a1bf0d3642764e5f646e1f3bbc8b1eeec474a77392d9aeb4868842b4cca"

Please move these just after SRC_URI.

> +LIC_FILES_CHKSUM =
> "file://macvlan_config.c;beginline=4;endline=62;md5=dc0660d77e4313e8ccdf256
> fbe436a63" +

Please move this towards the top (usually after the first block which includes 
LICENSE).

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre