Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: Using the OpenEmbedded metadata to build Distributions
	<openembedded-devel@openembedded.org>
Subject: mtn disapprove
Date: Fri, 11 Jan 2008 08:36:17 +0100	[thread overview]
Message-ID: <47871C71.5020800@student.utwente.nl> (raw)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

~From the commit messages:

- --
Zaurus machine config: fix code for creation of installkit for collie
* remove the code from collie config.  It is present in collie-2.6.inc
- --

That is factually correct, however instead of collie-2.6.inc you mean
zaurus-2.6.inc. Lets see:

koen@bitbake:~/OE/.dev/conf/machine$ grep require collie.conf
require conf/machine/include/collie-${MACHINE_KERNEL_VERSION}.inc
require conf/machine/include/tune-strongarm.inc
koen@bitbake:~/OE/.dev/conf/machine$ grep include collie.conf
require conf/machine/include/collie-${MACHINE_KERNEL_VERSION}.inc
require conf/machine/include/tune-strongarm.inc
koen@bitbake:~/OE/.dev/conf/machine$ grep require include/collie-2.*
koen@bitbake:~/OE/.dev/conf/machine$ grep include include/collie-2.*
koen@bitbake:~/OE/.dev/conf/machine$

Collie doesn't include zaurus-2.6.inc, which is why I added the code to
collie-2.6.inc a while ago so it would actually make an installkit,
which you broke now. Since I want an installkit (I wrote the installkit
code for that reason) I disapproved that commit.


- --
koen@dominion.kabel.utwente.nl will go go away in december 2007, please
use k.kooi@student.utwente.nl instead.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFHhxxxMkyGM64RGpERAjMwAJ9hLuwaCm7LczNWhE6ZxfGuOTeP2wCfUlDB
QSKivkNms6TjC/7CFL2g43g=
=TAlG
-----END PGP SIGNATURE-----



             reply	other threads:[~2008-01-11  7:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-11  7:36 Koen Kooi [this message]
2008-01-11  8:30 ` mtn disapprove Rolf Leggewie
2008-01-11  8:38   ` Koen Kooi
2008-01-11 16:53     ` Rolf Leggewie
2008-01-11 18:48       ` Rolf Leggewie
2008-01-11 19:20         ` Koen Kooi
2008-01-11 19:32           ` Rolf Leggewie
2008-01-11 23:22             ` Thomas Kunze
2008-01-12 10:39               ` Rolf Leggewie
2008-01-13 13:09                 ` Thomas Kunze
2008-01-13 15:06                   ` Rolf Leggewie
2008-01-13 16:30                     ` Koen Kooi
2008-01-14 11:21                       ` Florian Boor
2008-01-14 11:44                       ` Rolf Leggewie
2008-01-11 19:36       ` Rolf Leggewie
2008-01-11 11:06 ` ohviey1
  -- strict thread matches above, loose matches on Subject: below --
2008-01-11 20:57 QMan
2008-01-12 10:42 ` Rolf Leggewie
2008-01-12 11:41   ` Richard Purdie
2008-01-13 20:26 QMan
2008-01-28 13:51 ` Rolf Leggewie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47871C71.5020800@student.utwente.nl \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox