From: Thomas Kunze <thommycheck@gmx.de>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [oe-commits] : zaurus-2.6.inc: a string always is true, so test for the contents of it
Date: Tue, 23 Sep 2008 13:40:35 +0200 [thread overview]
Message-ID: <48D8D5B3.8010708@gmx.de> (raw)
In-Reply-To: <20080923110049.B007318806A@amethyst.openembedded.net>
OE GIT Trial schrieb:
> Module: OE.dev
> Branch: org.openembedded.dev
> Commit: 51e5f5be04d699828ab2f4a28e62ed6c789fb283
> URL: http://gitweb.openembedded.net//OE.dev.git/?a=commit;h=51e5f5be04d699828ab2f4a28e62ed6c789fb283
>
> Author: <koen@openembedded.org>
> Date: Tue Sep 23 10:41:38 2008 +0000
>
> zaurus-2.6.inc: a string always is true, so test for the contents of it
>
> ---
>
> conf/machine/include/zaurus-2.6.inc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/conf/machine/include/zaurus-2.6.inc b/conf/machine/include/zaurus-2.6.inc
> index 5e8f34f..a688f2f 100644
> --- a/conf/machine/include/zaurus-2.6.inc
> +++ b/conf/machine/include/zaurus-2.6.inc
> @@ -52,7 +52,7 @@ zaurus_make_installkit () {
> mkdir ${IMAGE_NAME}-installkit/
>
> # Get the latest kernel using the zImage-<machine>.bin symlink
> - if [ "${@base_contains('MACHINE_FEATURES', 'kexecboot', 'true', 'false',d)}" ]; then
> + if [ "${@base_contains('MACHINE_FEATURES', 'kexecboot', 'true', 'false',d)}" = "true" ]; then
>
Did you test the other solution? I meant to put the programcall 'true'
or 'false' in there. But I think I didn't test the negative case.
> [ -f "zImage-kexecboot-${MACHINE}.bin" ] && cp zImage-kexecboot-${MACHINE}.bin ${IMAGE_NAME}-installkit/zImage
> # we need also tgz for mmc or cf cards
> cp ${IMAGE_NAME}.rootfs.tar.gz ${IMAGE_NAME}-installkit/image.tgz
>
>
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
>
next parent reply other threads:[~2008-09-23 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080923110049.B007318806A@amethyst.openembedded.net>
2008-09-23 11:40 ` Thomas Kunze [this message]
2008-09-23 11:52 ` [oe-commits] : zaurus-2.6.inc: a string always is true, so test for the contents of it Koen Kooi
2008-09-25 10:12 ` Andrea Adami
2008-09-25 11:20 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D8D5B3.8010708@gmx.de \
--to=thommycheck@gmx.de \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox