From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: openembedded-devel@lists.openembedded.org
Subject: app launchers should NOT modify /proc/sys/vm
Date: Tue, 24 Nov 2009 13:29:32 +0100 [thread overview]
Message-ID: <4B0BD1AC.1010806@SSpaeth.de> (raw)
P.S. Sorry if this comes through twice. Dreamhost mail server was having
issues...
Currently, the navit (routing app) launcher script modifies
/proc/sys/vm/overcommit_memory without ever setting it back. This change
should -if at all- should only be done with serious evaluation on the
respective devices IMHO. I don't want to introduce random OOM process
killings for everyone because apps start using the RAM the kernel has
promised to them.
Do I get the OK to remove the launcher which is only doing this hackery?
I will follow up on this mail with a patch that you can ACK.
spaetz
Commit introducing this:
http://cgit.openembedded.net/cgit.cgi/openembedded/commit/?id=742fb4ae71e6a7e655385086ba9edebbf00b6ebd
author Matthias Hentges <oe@hentges.net>
committer Matthias Hentges <oe@hentges.net> 2008-01-05
commit 742fb4ae71e6a7e655385086ba9edebbf00b6ebd
--- a/dev/null
+++ b/packages/navit/files/navit.launcher
...
+ if test "$USER" = "root"
+ then
+ echo "Enabling low-mem workaround..."
+ echo 1 > /proc/sys/vm/overcommit_memory
next reply other threads:[~2009-11-24 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 12:29 Sebastian Spaeth [this message]
2009-11-24 12:53 ` [PATCH] navit: Do not set /proc/sys/vm/overcommit in an app launcher, especially not without ever changing it back Sebastian Spaeth
2009-11-24 22:50 ` Leon Woestenberg
-- strict thread matches above, loose matches on Subject: below --
2009-11-24 12:06 app launchers should NOT modify /proc/sys/vm Sebastian Spaeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0BD1AC.1010806@SSpaeth.de \
--to=sebastian@sspaeth.de \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox