Re: [PATCH] dhcp: Correct leases directory location

[Martyn Welch <martyn@welchs.me.uk>]

Marc Olzheim wrote:
> On Wed, Mar 31, 2010 at 07:01:29AM -0700, Steve Sakoman wrote:
>   
>> On Wed, 2010-03-31 at 14:29 +0100, Martyn Welch wrote:
>>     
>>> The DHCP client currently expects to be able to create a leases file in
>>> "/var/lib/dhcp" as configured in dhcp3.inc. Recipe is currently creating a
>>> directory called "/var/lib/dhcp3", resulting in the following error:
>>>
>>> can't create /var/lib/dhcp/dhclient.eth0.leases
>>>
>>> Correct directory naming to resolve error.
>>>
>>> Signed-off-by: Martyn Welch <martyn.welch@ge.com>
>>>
>>> ---
>>>
>>>  Steve: This seems to be directy reversing a change you made. The commit
>>>   message doesn't give me any idea of why you did it, can you remember?
>>>       
>> Interesting.  I made the change because I was getting quite similar
>> errors, but for files being created in /var/lib/dhcp3!
>>
>> I'm not sure what is different about our overall set ups, but perhaps
>> the proper fix is to create both directories.
>>
>> Steve
>>     
>
> Hmm, note that recipes/dhcp/files/init-server uses /var/lib/dhcp as well.
>
> dhclient from 3.1.2p1 uses /var/lib/dhcp by default. Maybe one of the
> older versions used /var/lib/dhcp3 by default...
>
> I did not spot this myself because dhclient is run from network-manager
> on our system, which passes it command line arguments on where to put
> the lease file.
>
> Marc
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>   

The contents of do_compile:

do_compile() {
        make RANLIB=${RANLIB} 
PREDEFINES='-D_PATH_DHCPD_DB=\"/var/lib/dhcp/dhcpd.leases\" \
        -D_PATH_DHCLIENT_DB=\"/var/lib/dhcp/dhclient.leases\" \
        -D_PATH_DHCLIENT_SCRIPT=\"/sbin/dhclient-script\" \
        -D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
        -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"'
}


Would suggest an explicit preference to using "var/lib/dhcp". May be 
there is another argument that has been missed?

Martyn