From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1.mentorg.com ([192.94.38.131]) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1OOaJy-0006NP-HZ for openembedded-devel@lists.openembedded.org; Tue, 15 Jun 2010 19:53:14 +0200 Received: from svr-orw-exc-08.mgc.mentorg.com ([147.34.98.97]) by relay1.mentorg.com with esmtp id 1OOaFc-0005um-Pr from Tom_Rini@mentor.com for openembedded-devel@lists.openembedded.org; Tue, 15 Jun 2010 10:48:40 -0700 Received: from na2-mail.mgc.mentorg.com ([134.86.114.213]) by SVR-ORW-EXC-08.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 15 Jun 2010 10:48:40 -0700 Received: from [172.30.80.129] ([172.30.80.129]) by na2-mail.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 15 Jun 2010 11:48:39 -0600 Message-ID: <4C17BCF4.30109@mentor.com> Date: Tue, 15 Jun 2010 10:48:36 -0700 From: Tom Rini Organization: Mentor Graphics Corporation User-Agent: Thunderbird 2.0.0.24 (X11/20100411) MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org References: <4C0D498A.4030709@mentor.com> In-Reply-To: <4C0D498A.4030709@mentor.com> X-OriginalArrivalTime: 15 Jun 2010 17:48:39.0506 (UTC) FILETIME=[FCCAEB20:01CB0CB2] X-SA-Exim-Connect-IP: 192.94.38.131 X-SA-Exim-Mail-From: Tom_Rini@mentor.com X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on discovery X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: Yes (on linuxtogo.org) Subject: Re: [PATCH, RFC] Add linux-libc-headers-native, make it default dep for native X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2010 17:53:15 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Tom Rini wrote: > On some host distributions the provided linux kernel headers are too old > to compile utilities we need[1]. Given that we need these utilities to > run things on the target the best solution is to provide > linux-libc-headers-native. Rather than get things into an inconsistent > state, we make linux-libc-headers-native be a default dependency. > > [1]: A prime example of this would be mtd-utils-native and UBI ping? The summary of the feedback, I believe would be: - Can we just make this opt-in for distros that need it? - Can we easily opt out if we don't? For the second, yes, ASSUME_PROVIDED still works. For the first, I'd argue that doing so is a lot harder (at least without some additional infrastructure and reliance on other external tools) than just adding another early package. So, yay or nay? > > diff --git a/classes/base.bbclass b/classes/base.bbclass > index e0f9184..e26a45e 100644 > --- a/classes/base.bbclass > +++ b/classes/base.bbclass > @@ -75,6 +75,12 @@ def base_dep_prepend(d): > if (bb.data.getVar('HOST_SYS', d, 1) != > bb.data.getVar('BUILD_SYS', d, 1)): > deps += " virtual/${TARGET_PREFIX}gcc virtual/libc " > + elif bb.data.inherits_class('native', d) and \ > + bb.data.getVar('PN', d, True) not in \ > + ("linux-libc-headers-native", "quilt-native", > + "unifdef-native", "shasum-native", > + "stagemanager-native", "coreutils-native"): > + deps += " linux-libc-headers-native" > return deps > > DEPENDS_prepend="${@base_dep_prepend(d)} " > diff --git a/recipes/linux-libc-headers/linux-libc-headers.inc > b/recipes/linux-libc-headers/linux-libc-headers.inc > index 0487e65..0b0d05a 100644 > --- a/recipes/linux-libc-headers/linux-libc-headers.inc > +++ b/recipes/linux-libc-headers/linux-libc-headers.inc > @@ -1,7 +1,8 @@ > DESCRIPTION = "Sanitized set of 2.6 kernel headers for the C library's > use." > SECTION = "devel" > LICENSE = "GPL" > +NATIVE_INSTALL_WORKS = "1" > +BBCLASSEXTEND = "native" > > RDEPENDS_${PN}-dev = "" > RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPV})" > - > diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.7.0.bb > b/recipes/linux-libc-headers/linux-libc-headers_2.6.7.0.bb > index b66e768..0a1159a 100644 > --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.7.0.bb > +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.7.0.bb > @@ -1,6 +1,7 @@ > require linux-libc-headers.inc > > INHIBIT_DEFAULT_DEPS = "1" > +NATIVE_INSTALL_WORKS = "0" > PR = "r4" > # NOTE: no need to package these headers, since the c library includes > them. > PACKAGES = "" > diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.8.1.bb > b/recipes/linux-libc-headers/linux-libc-headers_2.6.8.1.bb > index 4893cab..6cbd8ba 100644 > --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.8.1.bb > +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.8.1.bb > @@ -1,5 +1,6 @@ > require linux-libc-headers.inc > > +NATIVE_INSTALL_WORKS = "0" > HOMEPAGE = "http://ep09.pld-linux.org/~mmazur/linux-libc-headers/" > # license note from the package: > # Linux-libc-headers are derived from linux kernel headers. For > license of a -- Tom Rini Mentor Graphics Corporation