Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Detlef Vollmann <dv@vollmann.ch>
To: openembedded-devel@lists.openembedded.org
Subject: kernel_do_compile uses wrong kernel version
Date: Mon, 12 Jul 2010 01:58:28 +0200	[thread overview]
Message-ID: <4C3A5AA4.7090500@vollmann.ch> (raw)

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

kernel_do_compile in kernel.bbclass uses KERNEL_MAJOR_VERSION,
which is computed based on files that don't exist at that
point in time.
It's not a real problem, as a 'make dep' is still defined
and just gives a warning, but I attached a patch nevertheless.

BTW, I'm not sure how useful get_kernelversion() really is,
as for the DEPENDS the "2.6" or "2.4" needs to be computed
based on PV anyway.

   Detlef

[-- Attachment #2: kernel.bbclass.patch --]
[-- Type: text/x-diff, Size: 544 bytes --]

--- a/classes/kernel.bbclass	2010-06-14 00:02:08.000000000 +0200
+++ b/classes/kernel.bbclass	2010-07-12 01:49:03.000000000 +0200
@@ -85,7 +85,7 @@
 kernel_do_compile() {
 	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
 	oe_runmake include/linux/version.h CC="${KERNEL_CC}" LD="${KERNEL_LD}"
-	if [ "${KERNEL_MAJOR_VERSION}" != "2.6" ]; then
+	if [ "${@get_kernelmajorversion('${PV}')}" != "2.6" ]; then
 		oe_runmake dep CC="${KERNEL_CC}" LD="${KERNEL_LD}"
 	fi
 	oe_runmake ${KERNEL_IMAGETYPE} CC="${KERNEL_CC}" LD="${KERNEL_LD}"

                 reply	other threads:[~2010-07-12  0:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3A5AA4.7090500@vollmann.ch \
    --to=dv@vollmann.ch \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox