Re: [PATCH 1/2] mercurial-native: add recipe

[Graeme Gregory <dp@xora.org.uk>]

 On 07/09/10 07:27, Frans Meulenbroeks wrote:
> 2010/9/6 Eric Bénard <eric@eukrea.com>:
>> * mercurial is a distributed SCM
>> * having the native recipe inside OpenEmbedded gives the
>> possibility to fetch code from mercurial's repositories
>> without the need to have mercurial installed on the host
>>
>> Signed-off-by: Eric Bénard <eric@eukrea.com>
>> ---
>>  recipes/mercurial/mercurial-native_1.6.3.bb |   23 +++++++++++++++++++++++
>>  1 files changed, 23 insertions(+), 0 deletions(-)
>>  create mode 100644 recipes/mercurial/mercurial-native_1.6.3.bb
>>
>> diff --git a/recipes/mercurial/mercurial-native_1.6.3.bb b/recipes/mercurial/mercurial-native_1.6.3.bb
>> new file mode 100644
>> index 0000000..58fcaf1
>> --- /dev/null
>> +++ b/recipes/mercurial/mercurial-native_1.6.3.bb
>> @@ -0,0 +1,23 @@
>> +DESCRIPTION = "The Mercurial distributed SCM"
>> +SECTION = "console/utils"
>> +LICENSE = "GPLv2"
>> +
>> +SRC_URI = "http://mercurial.selenic.com/release/mercurial-${PV}.tar.gz;name=src"
>> +
>> +DEPENDS = "python-native"
>> +PR = "r0"
>> +
>> +S = "${WORKDIR}/mercurial-${PV}"
>> +EXTRA_OEMAKE = "STAGING_LIBDIR=${STAGING_LIBDIR} STAGING_INCDIR=${STAGING_INCDIR} \
>> +       BUILD_SYS=${BUILD_SYS} HOST_SYS=${HOST_SYS} PREFIX=${STAGING_DIR_NATIVE}/usr"
>> +
>> +do_install () {
>> +        install -d ${STAGING_DIR_NATIVE}/usr
> I'm a little bit surprised that you need this. I had expected install
> to take care of that.
> Otherwise, the recipe looks fine to me (but haven't test-build it yet)
>
Missed the original mail, but the install -d line should be in
do_install_prepend()

This makes it clearer that its a hack. You then also wont need to
specify the oe_runmake install bit.

Graeme