Re: [PATCH] linux-2.6.24: avoid kernel error if ubifs superblock read fails

[Steffen Sledz <sledz@dresearch.de>]

Am 27.09.2010 09:40, schrieb Frans Meulenbroeks:
>>> * .get_sb is called on mounts with automatic fs detection too, so this
>>>   function should not print an error if it cannot read the superblock
>>>   (new behaviour conforms the other fs types)
>>> ...
>
> Hm, I have some concerns:
> 
> the first concern is that mainline 2.6.34 still has the code you have deleted.
> I'd expect that others would have bumped into this too and that it
> would have been fixed this upstream.
> Since it isn't, chances are that upstream might have fixed the autofs
> detection in a different way.  If they do this differently maybe we
> should backport that solution.

I've suggested the same patch at the LKML and informed the UBIFS authors. But i do believe because of it's "low prio" it will need some time to go into the mainline.

> the second concern is that you fix it for a single version. If we feel
> this patch is needed, I would suggest applying the patch to all linux
> recipes.

Yes, that's true. I'll try to create a new patch.

> and the 3rd concern is that I am not too sure whether you do not
> remove a message that in other cases would be useful.

I did not found any other filesystem printing out such a message at this level.

Steffen

-- 
Steffen Sledz
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str.3, D-10319 Berlin, Germany
Tel: +49 (30) 515932237 mailto:sledz@DResearch.DE
Fax: +49 (30) 515932299 http://www.DResearch.DE
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 54412;
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642