Re: [PATCH v2] epiphany-2.30.2: unbreak do_configure by setting ca-file path

[Steffen Sledz <sledz@dresearch.de>]

Am 25.10.2010 13:37, schrieb Paul Menzel:
> Am Montag, den 25.10.2010, 11:55 +0200 schrieb Steffen Sledz:
>> * Disable existence check for ca-bundle file in configure.ac because
>>   it does not work in OE cross compile environment (location at build
>>   host may differ from location at target).
>> * Explicitely set ca-bundle file path according to the one used by
>>   ca-certificates package.
>> ...
>> ++# disable this check because it does not work in all environments
>> ++# (location at build host may differ from target)
>> ++#    if ! test -f "$with_ca_file"; then
>> ++#        AC_MSG_ERROR([No such file '$with_ca_file'. Use --with-ca-file=path to set, or --without-ca-file to disable])
>> ++#    fi
> 
> Would adding the following check also work?
> 
>         if test "$cross_compiling" != "yes"; then
>          …
>         fi

I don't think this is a good idea. It is not a problem of cross compiling. Cross compiling is just one case where it occurs.

Also if i build for the same architecture it is not a good idea to check for the existence of a file *at buildtime* and compile this path into the binary.

The existence of such a file should be checked and handled at runtime only.

> I think this would be more portable. Could you report that issue
> upstream too please.

I'll try.

Steffen