From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] pkgconfig.bbclass: don't blindly install every .pc file
Date: Sat, 13 Nov 2010 17:27:36 +0100 [thread overview]
Message-ID: <4CDEBC78.2020305@opendreambox.org> (raw)
In-Reply-To: <1288016459-30546-1-git-send-email-obi@opendreambox.org>
Ping
On 10/25/2010 04:20 PM, Andreas Oberritter wrote:
> * Instead of installing the file, print a log message. Later,
> this function could be removed.
> * .pc files must be installed explicitly to avoid causing
> build problems. E.g. libsoup-2.4-gnome.pc must not be
> installed if libsoup-2.4 is built without gnome support,
> because gstreamer would try to link against libsoup-2.4-gnome.
> * Fixes for lua5.1 and libid3tag, which install their own .pc
> files from OE, have been submitted.
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> ---
> classes/pkgconfig.bbclass | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
> index 23ab453..d96b708 100644
> --- a/classes/pkgconfig.bbclass
> +++ b/classes/pkgconfig.bbclass
> @@ -16,6 +16,8 @@ pkgconfig_sysroot_preprocess () {
> install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
> for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
> pcname=`basename $pc`
> - cat $pc > ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname
> + if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
> + oenote "$pcname was not installed."
> + fi
> done
> }
next prev parent reply other threads:[~2010-11-13 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 14:20 [PATCH] pkgconfig.bbclass: don't blindly install every .pc file Andreas Oberritter
2010-11-13 16:27 ` Andreas Oberritter [this message]
2010-11-16 17:05 ` Andreas Oberritter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDEBC78.2020305@opendreambox.org \
--to=obi@opendreambox.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox