From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 1/3] gtk+-1.2: convert to new style staging (fixes xmms build)
Date: Mon, 22 Nov 2010 15:07:51 +0100 [thread overview]
Message-ID: <4CEA7937.2070005@opendreambox.org> (raw)
In-Reply-To: <AANLkTinS-eXbu8JVq-eAt5+x=yu_rWZHRHSLJ4J3pCSt@mail.gmail.com>
On 11/22/2010 07:27 AM, Khem Raj wrote:
> On Sun, Nov 21, 2010 at 3:59 PM, Andreas Oberritter
> <obi@opendreambox.org> wrote:
>> * gtk+-1.2 didn't install its pkg-config file, but gtk-config
>> depended on it and went crazy without it. xmms uses gtk-config.
>>
>> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
>> Tested-by: Yury Bushmelev <jay4mail@gmail.com>
>
> while you are at it can you fix the license field to be more
> precise too ?
COPYING says LGPLv2, which could also mean LGPLv2+. Since I personally
don't care which of both it is, I won't read the detailed license text
and source code. Therefore no patch wrt. the license field.
> You dont have to resend the patch for review
> thanks for nailing it down
>
> Acked-by: Khem Raj <raj.khem@gmail.com>
Please apply the patches. My SSH key still hasn't been activated.
Regards,
Andreas
prev parent reply other threads:[~2010-11-22 14:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 23:59 [PATCH 1/3] gtk+-1.2: convert to new style staging (fixes xmms build) Andreas Oberritter
2010-11-21 23:59 ` [PATCH 2/3] swfdec-gnome: use the pkg-config file installed by swfdec Andreas Oberritter
2010-11-22 6:41 ` Khem Raj
2010-11-21 23:59 ` [PATCH 3/3] swfdec: remove unused old recipes Andreas Oberritter
2010-11-22 6:42 ` Khem Raj
2010-11-22 6:55 ` Frans Meulenbroeks
2010-11-22 2:31 ` [PATCH 1/3] gtk+-1.2: convert to new style staging (fixes xmms build) Philip Balister
2010-11-22 16:51 ` Paul Menzel
2010-11-22 6:27 ` Khem Raj
2010-11-22 14:07 ` Andreas Oberritter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA7937.2070005@opendreambox.org \
--to=obi@opendreambox.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox