From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH v2] strace_4.5.20.bb: Fix build on mips{, el} when DISTRO_FEATURES lacks "largefile".
Date: Tue, 23 Nov 2010 13:37:22 +0100 [thread overview]
Message-ID: <4CEBB582.3030106@opendreambox.org> (raw)
In-Reply-To: <4CEB3497.90607@gmail.com>
On 11/23/2010 04:27 AM, Graham Gower wrote:
> diff --git a/recipes/strace/strace_4.5.20.bb b/recipes/strace/strace_4.5.20.bb
> index 873ce52..086a4d7 100644
> --- a/recipes/strace/strace_4.5.20.bb
> +++ b/recipes/strace/strace_4.5.20.bb
> @@ -4,9 +4,13 @@ LICENSE = "GPL"
> PR = "r0"
>
> DEFAULT_PREFERENCE = "-1"
> +DEFAULT_PREFERENCE_mips = "1"
> +DEFAULT_PREFERENCE_mipsel = "1"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.bz2 \
> "
> +SRC_URI_append_mipsel += " file://mips-nolargefile.patch "
> +SRC_URI_append_mips += " file://mips-nolargefile.patch "
I think it would be better to apply this patch unconditionally, because
it doesn't impose negative effects on other archs, and future patches
which might only get compile-tested on other archs must make sure that
mips-nolargefile.patch still applies.
Regards,
Andreas
next prev parent reply other threads:[~2010-11-23 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 3:27 [PATCH v2] strace_4.5.20.bb: Fix build on mips{, el} when DISTRO_FEATURES lacks "largefile" Graham Gower
2010-11-23 12:37 ` Andreas Oberritter [this message]
2010-11-23 12:44 ` Andreas Oberritter
2010-11-25 17:24 ` mixing `vname_append` with `+=` (was: [PATCH v2] strace_4.5.20.bb: Fix build on mips{, el} when DISTRO_FEATURES lacks "largefile".) Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEBB582.3030106@opendreambox.org \
--to=obi@opendreambox.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox