Re: [PATCH v2 2/3] e2fsprogs: fix alternatives of non-packaged native sysroot

[Andreas Oberritter <obi@opendreambox.org>]

Hello Bernhard,

On 12/01/2010 08:15 PM, Bernhard Reutner-Fischer wrote:
> +do_install_append_pn-e2fsprogs () {
> +	for f in e2fsck mke2fs; do
> +		mv ${D}${base_sbindir}/$f ${D}${base_sbindir}/$f.${PN}
> +	done
> +	for f in chattr; do
> +		mv ${D}${bindir}/$f ${D}${bindir}/$f.${PN}
> +	done
> +	fsck=$(cd ${D}${base_sbindir}/ && ls -1 fsck.ext* | sed s/[^\.]*//)
> +	for e in $fsck;do
> +		rm ${D}${base_sbindir}/{fsck,mkfs}$e;

this doesn't work with dash. I had to split it into two seperate lines:

rm ${D}${base_sbindir}/fsck$e
rm ${D}${base_sbindir}/mkfs$e

> +		ln -s ${D}${base_sbindir}/e2fsck$e.${PN}$e fsck$e.${PN}
> +		ln -s ${D}${base_sbindir}/mke2fs$e.${PN}$e mkfs$e.${PN}

These two symlinks don't seem to make sense to me. I think this would be
right:

ln -sf e2fsck.${PN} ${D}${base_sbindir}/fsck$e.${PN}
ln -sf mke2fs.${PN} ${D}${base_sbindir}/mkfs$e.${PN}

Do you agree?

Regards,
Andreas