Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Tom Rini <tom_rini@mentor.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: bitbake does not fail when QA issues encountered
Date: Thu, 03 Feb 2011 16:09:27 -0700	[thread overview]
Message-ID: <4D4B35A7.4040000@mentor.com> (raw)
In-Reply-To: <20110203222035.GA19477@denix.org>

On 02/03/2011 03:20 PM, Denys Dmytriyenko wrote:
> On Thu, Feb 03, 2011 at 10:43:26AM -0700, Tom Rini wrote:
>> On 02/03/2011 12:09 AM, Denys Dmytriyenko wrote:
>>> On Thu, Jan 27, 2011 at 08:02:44AM -0700, Tom Rini wrote:
>>>> On 01/27/2011 04:27 AM, Frans Meulenbroeks wrote:
>>>>
>>>> The problem is that today we have QA Errors that are warnings
>>>> (coreutils-native) and QA Errors that result in a non-zero exit code but
>>>> also don't "kill the build" nor make it obvious at the end that there is
>>>> a
>>>> non-zero exit code (GNU_HASH, RPATH).  Finally we do have "kill the
>>>> build"
>>>> fatal checks in insane.bbclass, namely the do_qa_configure tests.
>>>
>>> Actually, I believe there was a simple error in the code which made QA
>>> Error
>>> on RPATH not kill the build[1]. BTW, GNU_HASH QA Error does stop the
>>> build.
>>>
>>> [1] http://thread.gmane.org/gmane.comp.handhelds.openembedded/42168
>>
>> Good spotting.  But.. GNU_HASH QA error will give you a non-zero exit code
>> and not kill the build so we're back where we started, albeit with a less
>> often hit in the community trigger (but I bet more often hit in private /
>> 3rd party collections).
>
> So, do you ack the patch, should I push it in? It will break the build for
> anyone still using libtool-2.2, specifically in gettext package...

So, that would break angstrom-2008.1 so I don't think that's a great 
idea until we fix it..

-- 
Tom Rini
Mentor Graphics Corporation



  reply	other threads:[~2011-02-03 23:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 19:37 bitbake does not fail when QA issues encountered Maupin, Chase
2011-01-25 20:58 ` Frans Meulenbroeks
2011-01-25 21:36   ` Khem Raj
2011-01-26 10:32     ` Martyn Welch
2011-01-26 15:03       ` Maupin, Chase
2011-01-26 15:27         ` Tom Rini
2011-01-27  9:38           ` Thomas Zimmermann
2011-01-27 11:27             ` Frans Meulenbroeks
2011-01-27 15:02               ` Tom Rini
2011-02-03  7:09                 ` Denys Dmytriyenko
2011-02-03 17:43                   ` Tom Rini
2011-02-03 22:20                     ` Denys Dmytriyenko
2011-02-03 23:09                       ` Tom Rini [this message]
2011-02-04  7:54                         ` Frans Meulenbroeks
2011-02-04  8:16                           ` Stefan Schmidt
2011-02-04  8:37                             ` Frans Meulenbroeks
2011-02-04  9:03                               ` Stefan Schmidt
2011-02-04  9:57                                 ` Frans Meulenbroeks
2011-02-04 12:42                                   ` Otavio Salvador
2011-02-04 13:10                                     ` Frans Meulenbroeks
2011-02-04 13:58                                       ` Andreas Mueller
2011-02-04 14:59                                   ` Tom Rini
2011-02-04 15:26                                     ` Frans Meulenbroeks
2011-02-04 15:52                                       ` Otavio Salvador
2011-02-05 13:35                                         ` Frans Meulenbroeks
2011-02-06  1:21                                           ` Otavio Salvador
2011-02-06 12:02                                             ` Frans Meulenbroeks
2011-02-09 20:02                                           ` Maupin, Chase
2011-02-09 20:13                                           ` Maupin, Chase
2011-02-10  6:32                                             ` Frans Meulenbroeks
2011-02-04 17:37                                       ` Tom Rini
2011-02-04 14:44                     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D4B35A7.4040000@mentor.com \
    --to=tom_rini@mentor.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox