From: Eric Benard <eric@eukrea.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] shadow: fix rpath issues
Date: Sat, 19 Feb 2011 15:36:43 +0100 [thread overview]
Message-ID: <4D5FD57B.30208@eukrea.com> (raw)
In-Reply-To: <4D5E8268.901@mentor.com>
Hi Tom,
On 18/02/2011 15:30, Tom Rini wrote:
> On 02/18/2011 05:30 AM, Eric Bénard wrote:
>> * add --disable-rpath (not enough with angstrom 2008.1)
>> * fix build problems with rpath on older libtool
>> * bump INC_PR
>>
>> Signed-off-by: Eric Bénard<eric@eukrea.com>>>
>> +do_configure_append () {
>> + # use same fix as libiconv
>> + sed -i -e s/^hardcode_libdir_flag_spec/#hardcode_libdir_flag_spec/ \
>> + -e s/^runpath_var/#runpath_var/ ${S}/*-libtool
>> +}
>> +
>> do_install_append() {
>> # Ensure that /etc/skel is created so any default files that we want copied
>> into new users home
>> # dirs can be put in there later (ideal for .xinitrc for example).
>
> The equiv I found in poky is:
> do_configure_append() {
> # Fix RPATH issues.
> sed -i ${S}/config.status -e s,^\\\(hardcode_into_libs=\\\).*$,\\1\'no\',
> ${S}/config.status
> }
>
> Any preference? Aside from I think we should be internally consistent in these
> fixes, so long as it's fixed...
>
after testing this one, it doesn't work for shadow (angstrom 2008.1 , armv5
target).
And poky's shadow is not fixed for rpath :
http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-extended/shadow/shadow.inc
Eric
prev parent reply other threads:[~2011-02-19 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 12:30 [PATCH] shadow: fix rpath issues Eric Bénard
2011-02-18 14:30 ` Tom Rini
2011-02-18 14:42 ` Eric Bénard
2011-02-18 15:33 ` Khem Raj
2011-02-19 14:36 ` Eric Benard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5FD57B.30208@eukrea.com \
--to=eric@eukrea.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox