From: Graeme Gregory <dp@xora.org.uk>
To: openembedded-devel@lists.openembedded.org
Subject: Re: MACHINE_KERNEL_PR overrides PR for modules
Date: Sun, 20 Feb 2011 10:40:04 +0000 [thread overview]
Message-ID: <4D60EF84.3070705@xora.org.uk> (raw)
In-Reply-To: <E1Pr64K-0003ub-00.nyrl-mail-ru@f253.mail.ru>
I think this patch is actually an indication that we need to rethink how
PR is generated and how it is abused
to contain SRCREV.
Graeme
On 20/02/2011 09:59, Denis Dydychkin wrote:
>
> When recipe inherits module.bbclass, it will get its PR overwritten if
> MACHINE_KERNEL_PR is defined. The outcome is that bumping PR within recipe has
> no effect, as well as SRCREV does not work anymore, which is especially
> important when working with latest version from repos.
>
> The following patch fixes this problem by appending MACHINE_KERNEL_PR to PR
> instead of replacing it. "+k" is added to get resulting PR looks like "r1+kr22"
> or "r1+svnr222+kr33" since MACHINE_KERNEL_PR is usually defined as "rXX".
>
>
> --- classes/module-base.bbclass 2011-02-17 16:14:45.792425264 +0300
> +++ classes/module-base.bbclass 2011-02-17 16:36:00.088425246 +0300
> @@ -11,7 +11,8 @@
> machine_kernel_pr = bb.data.getVar('MACHINE_KERNEL_PR', d, True)
>
> if machine_kernel_pr:
> - bb.data.setVar('PR', machine_kernel_pr, d)
> + pr = bb.data.getVar('PR', d, True) + "+k" + machine_kernel_pr
> + bb.data.setVar('PR', pr, d)
> }
>
> export KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}"
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
next prev parent reply other threads:[~2011-02-20 10:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 9:59 MACHINE_KERNEL_PR overrides PR for modules Denis Dydychkin
2011-02-20 10:40 ` Graeme Gregory [this message]
2011-02-20 11:26 ` Frans Meulenbroeks
2011-03-24 15:37 ` Andreas Oberritter
2011-03-24 16:00 ` Michael Smith
2011-03-24 16:22 ` Andreas Oberritter
2011-03-24 15:37 ` [PATCH] kernel/module-base: Append PR to MACHINE_KERNEL_PR Andreas Oberritter
2011-03-24 16:14 ` [PATCHv2] " Andreas Oberritter
2011-04-04 13:00 ` Andreas Oberritter
2011-04-04 13:58 ` Koen Kooi
2011-04-04 15:14 ` Andreas Oberritter
2011-04-04 17:54 ` Koen Kooi
2011-04-04 18:12 ` Tom Rini
2011-04-04 18:12 ` Andreas Oberritter
2011-04-05 6:22 ` Koen Kooi
2011-04-05 9:08 ` Andreas Oberritter
2011-04-05 9:23 ` Koen Kooi
2011-04-05 9:32 ` Phil Blundell
2011-04-05 10:39 ` Koen Kooi
2011-04-05 10:58 ` Phil Blundell
2011-04-05 11:31 ` Frans Meulenbroeks
2011-04-05 22:33 ` Mike Westerhof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D60EF84.3070705@xora.org.uk \
--to=dp@xora.org.uk \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox