Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Tom Rini <tom_rini@mentor.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: [PATCH 3/3] gst-ffmpeg: remove 4-year old hack that sets CC	directly
Date: Thu, 24 Feb 2011 18:22:22 -0700	[thread overview]
Message-ID: <4D67044E.5050303@mentor.com> (raw)
In-Reply-To: <1298590758-8843-3-git-send-email-denis@denix.org>

On 02/24/2011 04:39 PM, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko<denys@ti.com>
>
> The hack that sets CC variable directly is 4 year old and no longer required.
> On the other hand, it now breaks setups when --sysroot needs to be passed to
> the toolchain. Hence, remove the hack.
>
> Signed-off-by: Denys Dmytriyenko<denys@ti.com>

Acked-by: Tom Rini <tom_rini@mentor.com>

> ---
>   recipes/gstreamer/gst-ffmpeg_0.10.11.bb |    6 ++----
>   1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/recipes/gstreamer/gst-ffmpeg_0.10.11.bb b/recipes/gstreamer/gst-ffmpeg_0.10.11.bb
> index 3a6533a..563521e 100644
> --- a/recipes/gstreamer/gst-ffmpeg_0.10.11.bb
> +++ b/recipes/gstreamer/gst-ffmpeg_0.10.11.bb
> @@ -5,6 +5,8 @@ LICENSE = "LGPL"
>   HOMEPAGE = "http://www.gstreamer.net/"
>   DEPENDS = "ffmpeg gstreamer gst-plugins-base zlib"
>
> +PR = "r1"
> +
>   inherit autotools pkgconfig
>
>   SRC_URI = "http://gstreamer.freedesktop.org/src/${PN}/${PN}-${PV}.tar.bz2 \
> @@ -23,7 +25,3 @@ EXTRA_OECONF = " --with-system-ffmpeg "
>   # We do this because the install program is called with -s which causes it to
>   # call "strip" and it then mangles cross compiled stuff..
>   PATH_prepend := "${TOOLCHAIN_PATH}/${TARGET_SYS}/bin:"
> -
> -# Hack to get STAGING_LIBDIR into the linker path when building ffmpeg
> -CC = "${CCACHE} ${HOST_PREFIX}gcc ${TARGET_CC_ARCH} -L${STAGING_LIBDIR}"
> -


-- 
Tom Rini
Mentor Graphics Corporation



  reply	other threads:[~2011-02-25  1:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22  1:14 [PATCH 0/1] bitbake.conf: Simplify TARGET_CPPFLAGS/LDFLAGS Tom Rini
2011-02-22  1:14 ` [PATCH] " Tom Rini
2011-02-22  6:21   ` Khem Raj
2011-02-24  4:37     ` Denys Dmytriyenko
2011-02-24 15:57       ` Tom Rini
2011-02-24 16:47         ` Tom Rini
2011-02-24 23:39           ` [PATCH 1/3] bitbake.conf, native*.bbclass: pass --sysroot to TOOLCHAIN_OPTIONS Denys Dmytriyenko
2011-02-24 23:39             ` [PATCH 2/3] ffmpeg: pass --sysroot to configure script directly Denys Dmytriyenko
2011-02-25  1:22               ` Tom Rini
2011-02-24 23:39             ` [PATCH 3/3] gst-ffmpeg: remove 4-year old hack that sets CC directly Denys Dmytriyenko
2011-02-25  1:22               ` Tom Rini [this message]
2011-02-25  9:26               ` Koen Kooi
2011-02-25  1:21             ` [PATCH 1/3] bitbake.conf, native*.bbclass: pass --sysroot to TOOLCHAIN_OPTIONS Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D67044E.5050303@mentor.com \
    --to=tom_rini@mentor.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox