Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Simon Busch <morphis@gravedo.de>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: qt4-x11-free with PACKAGE_ARCH=palmpre :/
Date: Sat, 28 May 2011 16:27:17 +0200	[thread overview]
Message-ID: <4DE10645.9050108@gravedo.de> (raw)
In-Reply-To: <20110528080123.GR3222@jama.jama.net>

On 28.05.2011 10:01, Martin Jansa wrote:
> Hi,
> 
> 8a8dbc88232935835c1698cdf162bdf02fc1701b
> qt4-embedded: add palmpre specific profile script and bump PR
> 
> sets PACKAGE_ARCH_palmpre = "${MACHINE_ARCH}" only in 
> qt4-embedded.inc, but machine specific file
> qt4/files/palmpre/qte.sh
> is included *also* in shared qt-${PV}.inc SRC_URI
> 
> ./qt-4.7.3.inc:SRC_URI += "file://qte.sh"
> ./qt-4.6.3.inc:SRC_URI += "file://qte.sh"
> ./qt4-embedded.inc:SRC_URI += "file://qte.sh"
> 
> which makes qt4-x11-free also MACHINE_ARCH because of 
> utils.bbclass:machine_paths
> 
> I don't see qte.sh used in qt4-x11-free so I'm going to remove it from
> .inc file as well as PACKAGE_ARCH_palmpre which is detected fine by
> utils.bbclass.

Ok, I didn't that PACKAGE_ARCH is automatically set to MACHINE_ARCH when
I include a file subdirectory specific for that machine I am building for.

> I'll attach patch, please test, because I'm using qt4-x11-free only.

Will comment on the patch in a separate mail after I build the
qt4-embedded version with the patch included.

regards,
Simon



      parent reply	other threads:[~2011-05-28 14:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-28  8:01 qt4-x11-free with PACKAGE_ARCH=palmpre :/ Martin Jansa
2011-05-28  8:09 ` [PATCH] qt4: remove qte.sh from shared SRC_URI and PACKAGE_ARCH_palmpre Martin Jansa
2011-05-28 14:28   ` Simon Busch
2011-05-28 14:51     ` Martin Jansa
2011-05-28 14:27 ` Simon Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE10645.9050108@gravedo.de \
    --to=morphis@gravedo.de \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox