From: Holger Freyther <holger+oe@freyther.de>
To: openembedded-devel@lists.openembedded.org,
bitbake-devel@lists.openembedded.org
Subject: Re: RFC One recipe with two git repository as sources
Date: Fri, 01 Jul 2011 15:37:30 +0200 [thread overview]
Message-ID: <4E0DCD9A.4030508@freyther.de> (raw)
In-Reply-To: <1308828119.21613.138.camel@phil-desktop>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On 06/23/2011 01:21 PM, Phil Blundell wrote:
> On Thu, 2011-06-23 at 13:18 +0200, Holger Freyther wrote:
>> - destdir = os.path.join(destdir, "git/")
>> + destsuffix = ud.parm.get("destsuffix", "git/")
>> + print destsuffix
>> + destdir = os.path.join(destdir, destsuffix)
>
> I think that "print" might be extraneous, but other than this your patch
> looks awesome. I think this would resolve the problem that I was having
> in
> http://lists.linuxtogo.org/pipermail/openembedded-core/2011-June/004375.html and to which I never found a solution which didn't involve patching bitbake.
>
Hi all,
updated patch without the debug print statement in it. what do you think?
could this be applied to the bitbake repository?
holger
[-- Attachment #2: 0001-fetch2-git-Allow-to-specify-the-name-of-the-checkout.patch --]
[-- Type: text/x-patch, Size: 910 bytes --]
From 5f58446bd2022c149b58a9f8faf738d1b56597a6 Mon Sep 17 00:00:00 2001
From: Holger Hans Peter Freyther <zecke@selfish.org>
Date: Thu, 23 Jun 2011 04:50:13 +0800
Subject: [PATCH] fetch2/git: Allow to specify the name of the checkout directory
Signed-off-by: Holger Hans Peter Freyther <holger@moiji-mobile.com>
---
lib/bb/fetch2/git.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py
index f3bc793..534c87d 100644
--- a/lib/bb/fetch2/git.py
+++ b/lib/bb/fetch2/git.py
@@ -212,7 +212,8 @@ class Git(FetchMethod):
else:
readpathspec = ""
- destdir = os.path.join(destdir, "git/")
+ destsuffix = ud.parm.get("destsuffix", "git/")
+ destdir = os.path.join(destdir, destsuffix)
if os.path.exists(destdir):
bb.utils.prunedir(destdir)
--
1.7.4.1
prev parent reply other threads:[~2011-07-01 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 11:18 RFC One recipe with two git repository as sources Holger Freyther
2011-06-23 11:21 ` Phil Blundell
2011-06-23 11:36 ` Holger Freyther
2011-06-23 14:25 ` Phil Blundell
2011-06-23 14:37 ` Mark Hatle
2011-06-23 14:37 ` Koen Kooi
2011-07-01 13:37 ` Holger Freyther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0DCD9A.4030508@freyther.de \
--to=holger+oe@freyther.de \
--cc=bitbake-devel@lists.openembedded.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox