Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-oe][PATCH] giflib: don't depend on libsm if x11 is unavailable
Date: Thu, 02 Feb 2012 15:03:35 +0100	[thread overview]
Message-ID: <4F2A97B7.2080709@opendreambox.org> (raw)

If DISTRO_FEATURES doesn't contain x11, libsm is not available.
As libsm is optional, the dependency is changed to be conditional.
There's no need to alter configure flags, because without x11,
libsm cannot be picked up accidentially. Because this just fixes
a missing dependency failure without x11, no PR bump is required
either.

Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
 meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb b/meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb
index bd7b495..4e782e2 100644
--- a/meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb
+++ b/meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb
@@ -8,7 +8,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/giflib/${BP}.tar.bz2"
 
 inherit autotools
 
-DEPENDS = "libsm"
+DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', 'libsm', '', d)}"
 
 PACKAGES += "${PN}-utils"
 FILES_${PN} = "${libdir}/libgif.so.*"
-- 
1.7.5.4





             reply	other threads:[~2012-02-02 14:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 14:03 Andreas Oberritter [this message]
2012-02-08 18:11 ` [meta-oe][PATCH] giflib: don't depend on libsm if x11 is unavailable Andreas Oberritter
2012-02-08 18:41 ` Otavio Salvador
2012-02-08 19:35   ` Andreas Oberritter
2012-02-08 19:48     ` Otavio Salvador
2012-02-09  0:54       ` Andreas Oberritter
2012-02-09 12:41         ` [meta-oe][PATCH] giflib: don't link against libx11, don't depend on libsm Andreas Oberritter
2012-02-09 12:47           ` Otavio Salvador
2012-02-09 13:55           ` Paul Eggleton
2012-02-09 14:02           ` Paul Eggleton
2012-02-09 19:32             ` Henning Heinold
2012-02-09 18:50           ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2A97B7.2080709@opendreambox.org \
    --to=obi@opendreambox.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox