Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Felipe Ferreri Tonello <eu@felipetonello.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] qextserialport: Added 1.2rc recipe
Date: Wed, 27 Feb 2013 14:36:21 -0800	[thread overview]
Message-ID: <512E8A65.5070904@felipetonello.com> (raw)
In-Reply-To: <20130227203926.GE8208@jama.dyndns-home.com>

Hi Martin,

On 02/27/2013 12:39 PM, Martin Jansa wrote:
> On Wed, Feb 27, 2013 at 12:08:21PM -0800, eu@felipetonello.com wrote:
>> From: "Felipe F. Tonello" <ftonello@cercacor.com>
>>
>> QExtSerialPort is a serial port library for Qt4/5.
>
> Is there good reason to redefine all those FILES_*?
>
>  From previous mail:
> It also has a lot of QA warnings, it's better to use += for FILES_, so
> that default values are preserved where possible.
>

Ok. Got it. But in this case there is no more QA right. I know that I 
added the /usr/src/..., which is redundant, but still. If you want to me 
to remove, I can do it.

At least, someone that takes this recipe knows exactly what's been 
installed. IMO the default FILES_ might be obscure to some new contributors.

Thanks

Felipe

>>
>> Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
>> ---
>>   .../qextserialport/qextserialport_1.2rc.bb         |   56 ++++++++++++++++++++
>>   1 file changed, 56 insertions(+)
>>   create mode 100644 meta-oe/recipes-qt/qextserialport/qextserialport_1.2rc.bb
>>
>> diff --git a/meta-oe/recipes-qt/qextserialport/qextserialport_1.2rc.bb b/meta-oe/recipes-qt/qextserialport/qextserialport_1.2rc.bb
>> new file mode 100644
>> index 0000000..4cc9d6c
>> --- /dev/null
>> +++ b/meta-oe/recipes-qt/qextserialport/qextserialport_1.2rc.bb
>> @@ -0,0 +1,56 @@
>> +DESCRIPTION = "Qt Ext Serial Port Library"
>> +HOMEPAGE = "http://http://code.google.com/p/qextserialport/"
>> +LICENSE = "MIT"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b866a28cda707ec714878bd933f46251"
>> +SECTION = "qt/libs"
>> +
>> +PR = "r0"
>> +
>> +# 1.2rc as version will sort lower then 1.2 when it's released
>> +REAL_PV = "1.2rc"
>> +PV = "1.1+${REAL_PV}"
>> +
>> +inherit qt4x11 pkgconfig
>> +
>> +DEPENDS = "udev"
>> +
>> +SRC_URI = " \
>> +  http://qextserialport.googlecode.com/files/qextserialport-${REAL_PV}.zip \
>> +"
>> +
>> +SRC_URI[md5sum] = "ffa061edb9f64666468d18402eee6108"
>> +SRC_URI[sha256sum] = "9cbee267aac9830f9944bb1d13872e51fba400aa9afe158e64f0fe265a0176bc"
>> +
>> +S = "${WORKDIR}/qextserialport-${REAL_PV}"
>> +
>> +FILES_${PN} = "${libdir}/libqextserialport${SOLIBS}"
>> +
>> +FILES_${PN}-dev = " \
>> +  ${libdir}/libqextserialport${SOLIBSDEV} \
>> +  ${libdir}/libqextserialport.prl \
>> +  ${includedir}/QtExtSerialPort/*.h \
>> +  ${datadir}/qt4/mkspecs/features/extserialport.prf \
>> +"
>> +
>> +FILES_${PN}-dbg = " \
>> +  ${libdir}/.debug/libqextserialport.so* \
>> +  /usr/src/debug/qextserialport-${PV}-${PR}/qextserialport-${REAL_PV} \
>> +"
>> +
>> +do_configure_prepend() {
>> +  # based on the documentation, this line make sure we use udev in linux
>> +  cd ${S} && echo "linux*:CONFIG += qesp_linux_udev" > .qmake.cache
>> +
>> +  # Hacking hardcoded qmake variables
>> +  find *.pro -exec sed -i -e 's,$$\[QT_INSTALL_HEADERS\],${includedir},g' '{}' ';'
>> +  find *.pro -exec sed -i -e 's,$$\[QT_INSTALL_LIBS\],${libdir},g' '{}' ';'
>> +  find *.pro -exec sed -i -e 's,$$\[QMAKE_MKSPECS\],${datadir}/qt4/mkspecs/,g' '{}' ';'
>> +}
>> +
>> +do_install() {
>> +  export INSTALL_ROOT=${D}
>> +  oe_runmake install
>> +
>> +  # This is necessary to make it work with the qt based SDK
>> +  cd ${D}/${datadir}/qt4/mkspecs/features && sed -i -e "s|${STAGING_INCDIR_NATIVE}/qt4|\$(OE_QMAKE_INCDIR_QT)/..|" ./extserialport.prf
>> +}
>> --
>> 1.7.9.5




  reply	other threads:[~2013-02-27 22:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27 20:08 [meta-oe][PATCH] qextserialport: Added 1.2rc recipe eu
2013-02-27 20:39 ` Martin Jansa
2013-02-27 22:36   ` Felipe Ferreri Tonello [this message]
2013-02-28 23:47     ` Martin Jansa
2013-03-01 17:05       ` Felipe Ferreri Tonello
  -- strict thread matches above, loose matches on Subject: below --
2013-03-01 18:23 eu
2013-03-13 16:38 ` Martin Jansa
2013-02-20 19:40 eu
2013-02-26 23:36 ` Martin Jansa
2013-02-27 17:31   ` Felipe Ferreri Tonello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512E8A65.5070904@felipetonello.com \
    --to=eu@felipetonello.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox