Re: [meta-networking][PATCH] vpnc: Runtime dependency to perl was missing

[Jukka Rissanen <jukka.rissanen@linux.intel.com>]

Hi Koen,

On 13.05.2013 23:42, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 13-05-13 14:34, Jukka Rissanen schreef:
>> Generated package contains perl script but dependecy to perl was
>> missing.
>>
>> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> ---
>> meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +- 1 file
>> changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
>> b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb index
>> 2ce9530..df90234 100644 ---
>> a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb +++
>> b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb @@ -6,7 +6,7 @@
>> PRIORITY = "optional" LICENSE = "GPL-2.0+" LIC_FILES_CHKSUM =
>> "file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33" DEPENDS =
>> "libgcrypt" -RDEPENDS_${PN} = "kernel-module-tun" +RDEPENDS_${PN} =
>> "kernel-module-tun perl"
>
> I've seen a number of patches doing this and I hate it for 2 reasons:
>
> 1) the perl stuff should be looked at and split out in a subpackage whenever
> possible
> 2) it doesn't actually fix the problem, since you need to specify the
> perl-modules it needs as well.
>
> So patches like this drag in perl while at the same time not actually fixing
> the problem of failing runtimes, only papering over RPM bitching out
> dependencies.

Thanks, I missed that one. I will send a new version with proper dependency.


Cheers,
Jukka