From: Robert Yang <liezhi.yang@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-networking] [PATCH] traceroute: filter-out patches dir
Date: Fri, 14 Feb 2014 14:32:52 +0800 [thread overview]
Message-ID: <52FDB894.5090403@windriver.com> (raw)
In-Reply-To: <20140214032954.GL23405@deserted.net>
On 02/14/2014 11:29 AM, Joe MacDonald wrote:
> [Re: [oe] [meta-networking] [PATCH] traceroute: filter-out patches dir] On 14.02.13 (Thu 08:40) Otavio Salvador wrote:
>
>> On Thu, Feb 13, 2014 at 1:03 AM, Robert Yang <liezhi.yang@windriver.com> wrote:
>>>
>>>
>>> On 01/22/2014 10:21 PM, Otavio Salvador wrote:
>>>>
>>>> On Mon, Jan 20, 2014 at 10:52 AM, Robert Yang <liezhi.yang@windriver.com>
>>>> wrote:
>>>>>
>>>>> The $(subdirs) contains all the dirs under the ${B}, and this one:
>>>>>
>>>>> do_unpack[cleandirs] = "${S}/patches"
>>>>>
>>>>> will create a "patches" dir, then there will be compile errors, filter
>>>>> out the patches will fix the problem.
>>>>>
>>>>> Note: poky doesn't have this problem since it separates the ${S} and
>>>>> ${B}
>>>>>
>>>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>>
>>>>
>>>> Couldn't we change it for OE-Core as well? So we avoid having to patch
>>>> the build system.
>>>>
>>>
>>> I'm sorry, I don't quite understand what do you mean, this patch didn't
>>> change the build system, it changed the Make.rules.
>>
>>
>> To be sincere I didn't understand my comment as well ... don't recall
>> what I thought... I'd say to ignore it.
>
> Oh. Heh. I thought you were proposing a change to oe-core's build
> approach that would mean we didn't need to have a patch here to
> traceroute to separate $(B) and $(S). At least that's what I got from
> it based on the commit log. I'm still a bit confused about what's so
> different about traceroute's build system that it needs special handling
traceroute uses this:
EXEDIRS := $(filter-out $(INCLUDEDIRS) $(LIBDIRS) $(MODDIRS), $(subdirs))
the "patches" dir will be included in EXEDIRS which will cause errors, so
we need filter out it.
// Robert
> ...
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
next prev parent reply other threads:[~2014-02-14 6:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 12:52 [meta-networking] [PATCH] traceroute: filter-out patches dir Robert Yang
2014-01-22 14:21 ` Otavio Salvador
2014-02-13 0:59 ` Joe MacDonald
2014-02-13 3:03 ` Robert Yang
2014-02-13 10:40 ` Otavio Salvador
2014-02-14 3:29 ` Joe MacDonald
2014-02-14 6:32 ` Robert Yang [this message]
2014-03-18 9:24 ` Robert Yang
2014-03-27 20:28 ` Joe MacDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FDB894.5090403@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox