Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel@lists.openembedded.org,
	Mike Looijmans <milo-software@users.sourceforge.net>
Subject: Re: [PATCH] musicbrainz: Build with B=S
Date: Wed, 05 Mar 2014 20:49:37 +0100	[thread overview]
Message-ID: <53177FD1.2010407@topic.nl> (raw)
In-Reply-To: <20140305180816.GA26981@jama>

On 5-3-2014 19:08, Martin Jansa wrote:
> On Sat, Mar 01, 2014 at 06:54:47PM +0100, mike.looijmans@topic.nl wrote:
>> From: Mike Looijmans <milo-software@users.sourceforge.net>
>>
>> This recipe doesn't work when B!=S, so force B=$S to fix the failure.
>>
>> Signed-off-by: Mike Looijmans <milo-software@users.sourceforge.net>
> What's the relation of this change to
> http://patchwork.openembedded.org/patch/67597/
> ?

I suspect they both accomplish the same: Make the project compile again. 
Mine is the simplistic approach I guess - I did the least I could 
possible get away with... "Theirs" looks more like they actually 
understand what's going on

Mike.


>> ---
>>   .../musicbrainz/libmusicbrainz_git.bb              |    3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
>> index f6a8f53..4cc04b8 100644
>> --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
>> +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
>> @@ -37,3 +37,6 @@ do_configure_prepend() {
>>   
>>   EXTRA_OECMAKE = "-DLIB_INSTALL_DIR:PATH=${libdir} \
>>                    -DIMPORT_EXECUTABLES=build-native/ImportExecutables.cmake"
>> +
>> +# out-of-tree building doesn't appear to work for this package.
>> +B = "${S}"
>> -- 
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
Mike Looijmans



  reply	other threads:[~2014-03-05 19:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-01 17:54 [PATCH] musicbrainz: Build with B=S mike.looijmans
2014-03-05 18:08 ` Martin Jansa
2014-03-05 19:49   ` Mike Looijmans [this message]
2014-03-09  4:54     ` Tim Orling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53177FD1.2010407@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=martin.jansa@gmail.com \
    --cc=milo-software@users.sourceforge.net \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox