Re: [PATCH 1/3] vim: add dependency and selinux and acl support control

[Chong Lu <Chong.Lu@windriver.com>]

On 05/06/2014 05:45 AM, Paul Barker wrote:
> On Fri, Apr 18, 2014 at 06:16:30PM +0800, Chong Lu wrote:
>>   FILES_${PN}-data = "${datadir}/${PN}"
>> +FILES_${PN}-common = " \
>> +    ${datadir}/${PN}/${VIMDIR}/*.vim \
>> +    ${datadir}/${PN}/${VIMDIR}/autoload \
>> +    ${datadir}/${PN}/${VIMDIR}/colors \
>> +    ${datadir}/${PN}/${VIMDIR}/compiler \
>> +    ${datadir}/${PN}/${VIMDIR}/ftplugin \
>> +    ${datadir}/${PN}/${VIMDIR}/indent \
>> +    ${datadir}/${PN}/${VIMDIR}/keymap \
>> +    ${datadir}/${PN}/${VIMDIR}/lang \
>> +    ${datadir}/${PN}/${VIMDIR}/macros \
>> +    ${datadir}/${PN}/${VIMDIR}/plugin \
>> +    ${datadir}/${PN}/${VIMDIR}/print \
>> +    ${datadir}/${PN}/${VIMDIR}/spell \
>> +    ${datadir}/${PN}/${VIMDIR}/tools \
>> +"
>>   
>>   # Recommend that runtime data is installed along with vim
>>   RRECOMMENDS_${PN} = "${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc ${PN}-data"
> Sorry to reply to an old commit but this has broke things for me. Installing vim
> after this commit gives:
>
>      vim: unsatisfied recommendation for vim-data
>
> As everything that was in vim-data is now in vim-common. Your commit message
> says "Split binary file into vim package and put others in vim-common.", but
> this split was already in effect with everything in vim-data. It then got
> installed by default as vim-data is in RRECOMMENDS_vim, but could be disabled by
> adding things to BAD_RECOMMENDS.
>
> What is the benefit of moving things to vim-common? I'm probably just
> misunderstanding what this change is aiming to solve.
I just refer to Ubuntu splitting package policy.***
<https://bbs.archlinux.org/viewtopic.php?id=173515>*
>
> As vim-data is now left empty, can we remove it from PACKAGES and
> RRECOMMENDS_vim and instead add vim-common to RRECOMMENDS_vim? Just want to make
> sure that won't break anything for you before I send a patch.
Sorry for my mistake. we should remove vim-data from PACKAGES and 
RRECOMMENDS_vim and
add vim-common to RRECOMMENDS_vim.
> Thanks,
>