From: Kang Kai <Kai.Kang@windriver.com>
To: <openembedded-devel@lists.openembedded.org>,
Martin Jansa <martin.jansa@gmail.com>
Subject: Re: [meta-perl][PATCH 1/6] libdigest-sha1-perl: add recipe
Date: Thu, 14 Aug 2014 16:55:00 +0800 [thread overview]
Message-ID: <53EC7964.5050504@windriver.com> (raw)
In-Reply-To: <20140814085201.GF14848@jama>
On 2014?08?14? 16:52, Martin Jansa wrote:
> On Thu, Aug 14, 2014 at 04:42:19PM +0800, Kang Kai wrote:
>> On 2014?08?14? 16:38, Martin Jansa wrote:
>>> On Thu, Aug 14, 2014 at 04:02:02PM +0800, Kang Kai wrote:
>>>> This series of commits is for layer *meta-perl*, and I add it in cover
>>>> letter created by 'git send-email --compose', but it seems doesn't work.
>>> Please update indentation in them, you're using mix of tabs and spaces
>>> -> use 4 spaces everywhere.
>> Even in the shell function, such as
>>
>> +do_install_ptest () {
>> + cp -r ${B}/t ${D}${PTEST_PATH}
>> +}
>>
>>
>> I just thought it should be indented with tab.
> Yes, tabs in shell tasks are used only by oe-core, meta-oe, meta-smartphone, meta-qt5, meta-webos, ..
> are using consistent styleguide with 4 spaces everywhere.
OK. I'll sent V2.
Thanks a lot.
--Kai
>
>> If so, I'll update them and send V2.
>>
>> Thanks,
>> Kai
>>
>>>> On 2014?08?14? 15:49, Kai Kang wrote:
>>>>
>>>>
>>>>> Add recipe for libdigest-sha1-perl and enable create -ptest sub-package.
>>>>>
>>>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>>>> ---
>>>>> meta-perl/recipes-perl/libdigest/files/run-ptest | 16 ++++++++++++++
>>>>> .../libdigest/libdigest-sha1-perl_2.13.bb | 25 ++++++++++++++++++++++
>>>>> 2 files changed, 41 insertions(+)
>>>>> create mode 100644 meta-perl/recipes-perl/libdigest/files/run-ptest
>>>>> create mode 100644 meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb
>>>>>
>>>>> diff --git a/meta-perl/recipes-perl/libdigest/files/run-ptest b/meta-perl/recipes-perl/libdigest/files/run-ptest
>>>>> new file mode 100644
>>>>> index 0000000..1c008b5
>>>>> --- /dev/null
>>>>> +++ b/meta-perl/recipes-perl/libdigest/files/run-ptest
>>>>> @@ -0,0 +1,16 @@
>>>>> +#!/bin/sh
>>>>> +
>>>>> +for case in `find t -type f -name '*.t'`; do
>>>>> + perl $case >$case.output 2>&1
>>>>> + ret=$?
>>>>> + cat $case.output
>>>>> + if [ $ret -ne 0 ]; then
>>>>> + echo "FAIL: ${case%.t}"
>>>>> + elif grep -i 'SKIP' $case.output; then
>>>>> + echo "SKIP: ${case%.t}"
>>>>> + else
>>>>> + echo "PASS: ${case%.t}"
>>>>> + fi
>>>>> +
>>>>> + rm -f $case.output
>>>>> +done
>>>>> diff --git a/meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb b/meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb
>>>>> new file mode 100644
>>>>> index 0000000..42d5875
>>>>> --- /dev/null
>>>>> +++ b/meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb
>>>>> @@ -0,0 +1,25 @@
>>>>> +SUMMARY = "Perl interface to the SHA-1 algorithm "
>>>>> +DESCRIPTION = "Digest::SHA1 - Perl interface to the SHA-1 algorithm"
>>>>> +HOMEPAGE = "http://search.cpan.org/~gaas/Digest-SHA1-2.13/"
>>>>> +SECTION = "libs"
>>>>> +
>>>>> +LICENSE = "Artistic-1.0|GPLv1+"
>>>>> +LIC_FILES_CHKSUM = "file://README;beginline=10;endline=14;md5=ff5867ebb4bc1103a7a416aef2fce00a"
>>>>> +
>>>>> +SRC_URI = "http://search.cpan.org/CPAN/authors/id/G/GA/GAAS/Digest-SHA1-${PV}.tar.gz \
>>>>> + file://run-ptest \
>>>>> + "
>>>>> +SRC_URI[md5sum] = "bd22388f268434f2b24f64e28bf1aa35"
>>>>> +SRC_URI[sha256sum] = "68c1dac2187421f0eb7abf71452a06f190181b8fc4b28ededf5b90296fb943cc"
>>>>> +
>>>>> +S = "${WORKDIR}/Digest-SHA1-${PV}"
>>>>> +
>>>>> +inherit cpan ptest
>>>>> +
>>>>> +do_install_ptest () {
>>>>> + cp -r ${B}/t ${D}${PTEST_PATH}
>>>>> +}
>>>>> +
>>>>> +BBCLASSEXTEND="native"
>>>>> +
>>>>> +FILES_${PN}-dbg =+ "${libdir}/perl/vendor_perl/*/auto/Digest/SHA1/.debug/"
>>>> --
>>>> Regards,
>>>> Neil | Kai Kang
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>
>> --
>> Regards,
>> Neil | Kai Kang
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
--
Regards,
Neil | Kai Kang
prev parent reply other threads:[~2014-08-14 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 7:49 [PATCH 1/6] libdigest-sha1-perl: add recipe Kai Kang
2014-08-14 7:49 ` [PATCH 2/6] libdigest-hmac-perl: " Kai Kang
2014-08-14 7:49 ` [PATCH 3/6] libauthen-sasl-perl: " Kai Kang
2014-08-14 7:49 ` [PATCH 4/6] libnet-ssleay-perl: " Kai Kang
2014-08-14 7:49 ` [PATCH 5/6] libio-socket-ssl-perl: " Kai Kang
2014-08-14 7:49 ` [PATCH 6/6] libmime-types-perl: " Kai Kang
2014-08-14 8:02 ` [meta-perl][PATCH 1/6] libdigest-sha1-perl: " Kang Kai
2014-08-14 8:38 ` Martin Jansa
2014-08-14 8:42 ` Kang Kai
2014-08-14 8:52 ` Martin Jansa
2014-08-14 8:55 ` Kang Kai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EC7964.5050504@windriver.com \
--to=kai.kang@windriver.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox