From: Mike Looijmans <mike.looijmans@topic.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 02/14] autofs: add bash to RDEPENDS_autofs
Date: Wed, 10 Sep 2014 19:08:37 +0200 [thread overview]
Message-ID: <54108595.6080809@topic.nl> (raw)
In-Reply-To: <63e89adc5ffc2c1e30a4b2a41ca0988e95158554.1410279874.git.liezhi.yang@windriver.com>
Wouldn't it be a LOT more constructive to fix the bashism. I fail to see
the virtue in adding 2MB of "bash" to an embedded system just for a text
echo statement that no-one will actually read unless they hook up a
serial console to their TV set or so.
On 9-9-2014 18:27, Robert Yang wrote:
> Bashism:
> [snip]
> possible bashism in autofs/etc/init.d/autofs line 116 ($"foo" should be eval_gettext "foo"):
> echo $"$prog not running"
> possible bashism in autofs/etc/init.d/autofs line 120 ($"foo" should be eval_gettext "foo"):
> echo $"Reloading maps"
> possible bashism in autofs/etc/init.d/autofs line 150 ($"foo" should be eval_gettext "foo"):
> echo $"Usage: $0 {start|forcestart|stop|restart|forcerestart|reload}"
> [snip]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> .../recipes-daemons/autofs/autofs_5.1.0.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb b/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb
> index aab2187..06ee77b 100644
> --- a/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb
> +++ b/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb
> @@ -4,6 +4,7 @@ LICENSE = "GPL-2.0"
> LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>
> DEPENDS += "libtirpc flex-native bison-native"
> +RDEPENDS_${PN} += "bash"
>
> inherit autotools-brokensep systemd
>
>
--
Mike Looijmans
next prev parent reply other threads:[~2014-09-10 17:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 16:27 [PATCH 00/14 V2] fix RDEPENDS issues Robert Yang
2014-09-09 16:27 ` [PATCH 01/14] aoetools: no bashism in aoe-stat Robert Yang
2014-09-09 16:27 ` [PATCH 02/14] autofs: add bash to RDEPENDS_autofs Robert Yang
2014-09-10 17:08 ` Mike Looijmans [this message]
2014-09-11 15:28 ` Robert Yang
2014-09-12 12:57 ` Mike Looijmans
2014-09-12 13:01 ` Robert Yang
2014-09-14 4:13 ` Robert Yang
2014-09-15 14:03 ` Mike Looijmans
2014-09-11 16:02 ` Enrico Scholz
2014-09-09 16:27 ` [PATCH 03/14] arptables: add bash to RDEPENDS_arptables Robert Yang
2014-09-09 16:27 ` [PATCH 04/14] ndisc6: add perl to RDEPENDS_ndisc6-misc Robert Yang
2014-09-09 16:27 ` [PATCH 05/14] stunnel: add perl to RDEPENDS_stunnel Robert Yang
2014-09-09 16:27 ` [PATCH 06/14] proftpd: add perl to RDEPENDS_proftpd Robert Yang
2014-09-09 16:27 ` [PATCH 07/14] memcached: add bash to RDEPENDS_memcached Robert Yang
2014-09-09 16:27 ` [PATCH 08/14] phpmyadmin: add bash to RDEPENDS_phpmyadmin Robert Yang
2014-09-09 16:27 ` [PATCH 09/14] apache2: split apache2-scripts subpkg Robert Yang
2014-09-09 16:27 ` [PATCH 10/14] sg3-utils: add bash to RDEPENDS_sg3-utils Robert Yang
2014-09-09 16:27 ` [PATCH 11/14] sdparm: split sdparm-scripts subpkg Robert Yang
2014-09-09 16:27 ` [PATCH 12/14] bonnie++: add perl to RDEPENDS_bonnie-scripts Robert Yang
2014-09-09 16:27 ` [PATCH 13/14] rrdtool: use rrdtool rather than PN Robert Yang
2014-09-09 16:27 ` [PATCH 14/14] webmin: fix hardcode of python2.3 Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54108595.6080809@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox