Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 03/13] arptables: add bash to RDEPENDS_arptables
Date: Thu, 18 Sep 2014 00:42:21 -0700	[thread overview]
Message-ID: <541A8CDD.6000303@gmail.com> (raw)
In-Reply-To: <1ab2a6a84a7ad1e930aadb138a807a58ee65d065.1409584344.git.liezhi.yang@windriver.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 9/1/14 8:18 AM, Robert Yang wrote:
> Bashism:
> possible bashism in arptables/etc/init.d/arptables line 14 (should be '.', not 'source'):
> source /etc/init.d/functions
> possible bashism in arptables/etc/init.d/arptables line 96 ($"foo" should be eval_gettext "foo"):
>         echo $"Usage $0 {start|stop|restart|condrestart|save|status}"

could these be patched instead of rdepending on bash
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  .../recipes-support/arptables/arptables_0.0.3-4.bb |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-support/arptables/arptables_0.0.3-4.bb b/meta-networking/recipes-support/arptables/arptables_0.0.3-4.bb
> index 74f81b5..94920f9 100644
> --- a/meta-networking/recipes-support/arptables/arptables_0.0.3-4.bb
> +++ b/meta-networking/recipes-support/arptables/arptables_0.0.3-4.bb
> @@ -5,7 +5,7 @@ SECTION = "console/network"
>  
>  PR = "r2"
>  
> -RDEPENDS_${PN} += "perl"
> +RDEPENDS_${PN} += "perl bash"
>  
>  LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
>  SRC_URI = " \
> 

- -- 
- -Khem
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org

iEYEARECAAYFAlQajN0ACgkQuwUzVZGdMxSHuACdFnp3LZpRjZsN3IVLm2tCCb8L
y2kAnRFWsf2R9HDvvAp1xUoSnQB9bZfQ
=ZfQX
-----END PGP SIGNATURE-----


  reply	other threads:[~2014-09-18  7:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01 15:18 [PATCH 00/13] fix RDEPENDS issues Robert Yang
2014-09-01 15:18 ` [PATCH 01/13] aoetools: no bashism in aoe-stat Robert Yang
2014-09-01 15:18 ` [PATCH 02/13] autofs: add bash to RDEPENDS_autofs Robert Yang
2014-09-01 15:18 ` [PATCH 03/13] arptables: add bash to RDEPENDS_arptables Robert Yang
2014-09-18  7:42   ` Khem Raj [this message]
2014-09-19  3:03     ` Robert Yang
2014-09-01 15:18 ` [PATCH 04/13] ndisc6: add perl to RDEPENDS_ndisc6-misc Robert Yang
2014-09-01 15:18 ` [PATCH 05/13] stunnel: add perl to RDEPENDS_stunnel Robert Yang
2014-09-01 15:18 ` [PATCH 06/13] proftpd: add perl to RDEPENDS_proftpd Robert Yang
2014-09-01 15:18 ` [PATCH 07/13] memcached: add bash to RDEPENDS_memcached Robert Yang
2014-09-01 15:18 ` [PATCH 08/13] phpmyadmin: add bash to RDEPENDS_phpmyadmin Robert Yang
2014-09-01 15:18 ` [PATCH 09/13] apache2: add perl to RDEPENDS_apache2 Robert Yang
2014-09-02  8:31   ` Olof Johansson
2014-09-02  8:45     ` Robert Yang
2014-09-02  8:52       ` Olof Johansson
2014-09-02 12:54     ` [PATCH 09/13] apache2: split apache2-scripts subpkg Robert Yang
2014-09-01 15:18 ` [PATCH 10/13] sg3-utils: add bash to RDEPENDS_sg3-utils Robert Yang
2014-09-01 15:18 ` [PATCH 11/13] sdparm: add bash to RDEPENDS_sdparm Robert Yang
2014-09-04 21:10   ` Randy MacLeod
2014-09-05  1:58     ` Robert Yang
2014-09-01 15:18 ` [PATCH 12/13] bonnie: add perl to RDEPENDS_bonnie-scripts Robert Yang
2014-09-01 15:18 ` [PATCH 13/13] rrdtool: use rrdtool rather than PN Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541A8CDD.6000303@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox