Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: "Peter A. Bigot" <pab@pabigot.com>
To: Rongqing Li <rongqing.li@windriver.com>,
	 openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH v2] ntp: add deterministic support for KPPS interface
Date: Mon, 29 Sep 2014 05:19:38 -0500	[thread overview]
Message-ID: <5429323A.4060300@pabigot.com> (raw)
In-Reply-To: <54290F57.6090500@windriver.com>

On 09/29/2014 02:50 AM, Rongqing Li wrote:
>
>
> On 08/29/2014 01:43 AM, Peter A. Bigot wrote:
>> ntp checks for presence of sys/timepps.h to determine whether the kernel
>> supports the RFC 2783 KPPS interface.  Under Linux the pps-tools package
>> installs this header.  Without this feature the ATOM clock driver does
>> not work, and other drivers like NMEA have reduced precision. Remove
>> the feature non-determinism and increase ntpd capabilities by adding an
>> explicit dependency.
>>
>> See: http://doc.ntp.org/4.2.6/kernpps.html
>>
>> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
>> ---
>> V2: replace PACKAGECONFIG with DEPENDS to remove nondeterminism
>>
>>   meta-networking/recipes-support/ntp/ntp.inc | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-networking/recipes-support/ntp/ntp.inc 
>> b/meta-networking/recipes-support/ntp/ntp.inc
>> index 55926e0..f55a39a 100644
>> --- a/meta-networking/recipes-support/ntp/ntp.inc
>> +++ b/meta-networking/recipes-support/ntp/ntp.inc
>> @@ -8,6 +8,8 @@ SECTION = "console/network"
>>   LICENSE = "NTP"
>>   LIC_FILES_CHKSUM = 
>> "file://COPYRIGHT;md5=fea4b50c33b18c2194b4b1c9ca512670"
>>
>> +DEPENDS = "pps-tools"
>
> Could we add this dependent by PACKAGECONFIG?

That was my original intent, but it was rejected as non-deterministic.  
See discussion at: http://patchwork.openembedded.org/patch/79279/

Peter


      reply	other threads:[~2014-09-29 10:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 12:06 [meta-oe][PATCH 0/5] ntpd and gpsd updates for high-precision timing Peter A. Bigot
2014-08-28 12:06 ` [meta-oe][PATCH 1/5] ntp: re-enable server debugging and control by PACKAGECONFIG Peter A. Bigot
2014-08-28 12:06 ` [meta-oe][PATCH 2/5] gpsd: update to 3.10 Peter A. Bigot
2014-08-28 12:06 ` [meta-oe][PATCH 3/5] pps-tools: add recipe Peter A. Bigot
2014-08-28 12:06 ` [meta-oe][PATCH 4/5] gpsd: add optional support for KPPS interface Peter A. Bigot
2014-08-28 12:53   ` Burton, Ross
2014-08-28 13:05     ` Peter A. Bigot
2014-08-28 14:32       ` Martin Jansa
2014-08-28 15:23         ` Peter A. Bigot
2014-08-28 15:47           ` Martin Jansa
2014-08-28 15:51             ` Peter A. Bigot
2014-08-28 15:48           ` Peter A. Bigot
2014-08-28 16:25             ` Martin Jansa
2014-08-28 14:29   ` Martin Jansa
2014-08-28 17:42   ` [meta-oe][PATCH v2] gpsd: add deterministic " Peter A. Bigot
2014-08-28 12:06 ` [meta-oe][PATCH 5/5] ntp: add optional " Peter A. Bigot
2014-08-28 17:43   ` [meta-networking][PATCH v2] ntp: add deterministic " Peter A. Bigot
2014-09-29  7:50     ` Rongqing Li
2014-09-29 10:19       ` Peter A. Bigot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5429323A.4060300@pabigot.com \
    --to=pab@pabigot.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=rongqing.li@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox