Re: [meta-oe][PATCH v3] tiptop: Add new recipe

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Qian Lei schreef op 27-11-14 10:19:
> Tiptop is a performance monitoring tool for Linux. It provides a dynamic
> real-time view of the tasks running in the system. Tiptop is very similar
> to the top utility, but most of the information displayed comes from
> hardware counters.
> 
> Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com> --- 
> meta-oe/recipes-extended/tiptop/tiptop_2.2.bb | 26
> ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode
> 100644 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> 
> diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb new file mode 100644 
> index 0000000..126976c --- /dev/null +++
> b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb @@ -0,0 +1,26 @@ +SUMMARY
> = "Hardware performance monitoring counters" +HOMEPAGE =
> "http://tiptop.gforge.inria.fr/" +LICENSE = "GPLv2" +LIC_FILES_CHKSUM =
> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" +DEPENDS = "ncurses
> libxml2" + +SRC_URI =
> "http://tiptop.gforge.inria.fr/releases/${BP}.tar.gz" +SRC_URI[md5sum] =
> "74255a29acf44569db021b080ad3e3f7" +SRC_URI[sha256sum] =
> "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d" + 
> +inherit autotools-brokensep +EXTRA_OECONF = "CFLAGS="$CFLAGS
> -I${STAGING_INCDIR}/libxml2"" +COMPATIBLE_HOST =
> "(i.86|x86_64|arm|powerpc).*-linux"

What's broken on mips, armv8 and avr32?

> + +do_configure_prepend () { +    # Two bugs in configure.ac when
> cross-compiling. +    # 1. The path of libxml2. Specify it in
> EXTRA_OECONF. +    # 2. hw's value on other platforms. Replace it if the
> target is +    #    not i*86/x86_64. +    if ( echo "${TARGET_ARCH}" |
> grep -q -e 'i.86' -e 'x86_64' ); then +        sed -i 's=
> -I/usr/include/libxml2=='    ${S}/configure.ac +    else +        sed -i
> 's/hw=`uname -m`/hw="unknown"/'  ${S}/configure.ac +        sed -i 's=
> -I/usr/include/libxml2=='    ${S}/configure.ac +    fi +}

Drop the conditional, it should *never* use uname.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFUdvGrMkyGM64RGpERAia5AJwKkcp5N1xKAWHA1kCbReH+iwZsWwCfaWvi
5gv7MvkZZz3lICXG/L4O3Xo=
=oxk6
-----END PGP SIGNATURE-----