Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH 1/2] mplayer2: use B = "${S}"
Date: Fri, 05 Dec 2014 04:44:55 -0700	[thread overview]
Message-ID: <54819AB7.1000400@mlbassoc.com> (raw)
In-Reply-To: <1417779660-18387-1-git-send-email-awais_belal@mentor.com>

On 2014-12-05 04:40, Awais Belal wrote:
> The mplayer2 package does not support out of tree builds
> and the do_configure step also tries to find the configure
> script in the same build directory while the script lies in
> the src directory.
> This patch updates the builddir to point to the srcdir in
> order to cope with the above issues.
>
> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
>   meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 65fab1f..4656057 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -29,6 +29,7 @@ PR = "r13"
>   PARALLEL_MAKE = ""
>
>   S = "${WORKDIR}/git"
> +B = "${S}"
>
>   FILES_${PN} = "${bindir}/mplayer ${libdir} /usr/etc/mplayer/"
>   CONFFILES_${PN} += "/usr/etc/mplayer/input.conf \
>

It would probably be better to just inherit autoconf-brokensep
which does the same thing but documents the reason for the change.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


      parent reply	other threads:[~2014-12-05 11:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 11:40 [meta-oe][PATCH 1/2] mplayer2: use B = "${S}" Awais Belal
2014-12-05 11:41 ` [meta-oe][PATCH 2/2] mplayer2: cleanup empty directories Awais Belal
2014-12-05 12:48   ` Martin Jansa
2014-12-05 21:45     ` Belal, Awais
2014-12-05 11:44 ` Gary Thomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54819AB7.1000400@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox