Re: [meta-networking][PATCH V2] netkit-tftp: new package

[akuster808 <akuster808@gmail.com>]

thanks.

- armin

On 12/17/2014 10:16 AM, Martin Jansa wrote:
> On Wed, Dec 17, 2014 at 09:47:11AM -0800, akuster808 wrote:
>>
>> ok. thanks for the feedback.
>
> FYI: I've also fixed it in master-next.
>
> I've shortened the DESCRIPTION a bit, if you want package specific
> description it could be set with package qualifier.
>
> I've removed V2: .. from commit message (I guess you wanted to include
> it bellow ---.
>
> I've dropped leading space from DEPENDS.
>
>> On 12/17/2014 08:35 AM, Martin Jansa wrote:
>>> On Sat, Dec 13, 2014 at 10:03:32AM -0800, Armin Kuster wrote:
>>>> V2: fix license
>>>>       moved xinent.d config to file
>>>>       remove INSANE
>>>
>>> Missing line-feed before LICENSE variable, doesn't even parse because
>>> bitbake doesn't see LICENSE..
>>>
>>> ERROR: This recipe does not have the LICENSE field set (netkit-tftp)
>>> ERROR: Failed to parse recipe: /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-netkit/netkit-tftp/netkit-tftp_0.17.bb
>>> ETA:  00:01:48
>>>
>>>>
>>>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>>>> ---
>>>>    .../netkit-tftp/netkit-tftp/tftp.conf              | 11 +++++
>>>>    .../recipes-netkit/netkit-tftp/netkit-tftp_0.17.bb | 54 ++++++++++++++++++++++
>>>>    2 files changed, 65 insertions(+)
>>>>    create mode 100644 meta-networking/recipes-netkit/netkit-tftp/netkit-tftp/tftp.conf
>>>>    create mode 100644 meta-networking/recipes-netkit/netkit-tftp/netkit-tftp_0.17.bb
>>>>
>>>> diff --git a/meta-networking/recipes-netkit/netkit-tftp/netkit-tftp/tftp.conf b/meta-networking/recipes-netkit/netkit-tftp/netkit-tftp/tftp.conf
>>>> new file mode 100644
>>>> index 0000000..7bc6ca9
>>>> --- /dev/null
>>>> +++ b/meta-networking/recipes-netkit/netkit-tftp/netkit-tftp/tftp.conf
>>>> @@ -0,0 +1,11 @@
>>>> +service tftp
>>>> +{
>>>> +    disable        = no
>>>> +    socket_type    = dgram
>>>> +    port           = 69
>>>> +    protocol       = udp
>>>> +    wait           = yes
>>>> +    user           = nobody
>>>> +    server         = /usr/sbin/in.tftpd
>>>> +    server_args    = /tftpboot
>>>> +}
>>>> diff --git a/meta-networking/recipes-netkit/netkit-tftp/netkit-tftp_0.17.bb b/meta-networking/recipes-netkit/netkit-tftp/netkit-tftp_0.17.bb
>>>> new file mode 100644
>>>> index 0000000..43075d7
>>>> --- /dev/null
>>>> +++ b/meta-networking/recipes-netkit/netkit-tftp/netkit-tftp_0.17.bb
>>>> @@ -0,0 +1,54 @@
>>>> +DESCRIPTION = " tftp - Trivial file transfer protocol client \
>>>> +    tftpd- Trivial file transfer protocol server "
>>>> +SECTION = "networking" LICENSE = "BSD-4-Clause"
>>>> +DEPENDS = " tcp-wrappers"
>>>> +
>>>> +LIC_FILES_CHKSUM = "file://tftp/tftp.c;beginline=2;endline=3;md5=84d2cfe1e60863a7d82648734ba4d30c"
>>>> +
>>>> +SRC_URI = "${DEBIAN_MIRROR}/main/n/${BPN}/${BPN}_${PV}.orig.tar.gz;name=archive \
>>>> +        ${DEBIAN_MIRROR}/main/n/${BPN}/${BPN}_${PV}-18.diff.gz;name=patch18 \
>>>> +        file://tftp.conf \
>>>> +"
>>>> +
>>>> +SRC_URI[archive.md5sum] = "b7262c798e2ff50e29c2ff50dfd8d6a8"
>>>> +SRC_URI[archive.sha256sum] = "3a43c0010d4e61f412563fd83769d4667d8b8e82903526d21cb9205fe55ad14d"
>>>> +SRC_URI[patch18.md5sum] = "cb29e7a33dd85105ba6e6ec4f971e42c"
>>>> +SRC_URI[patch18.sha256sum] = "092437d27b4fa88c044ef6290372fee5ce06d223607f0e22a6e527065c8930e7"
>>>> +
>>>> +inherit autotools-brokensep
>>>> +
>>>> +do_configure () {
>>>> +    ./configure --prefix=${prefix}
>>>> +    echo "CFLAGS=${CFLAGS}" > MCONFIG
>>>> +}
>>>> +
>>>> +do_compile () {
>>>> +    oe_runmake 'CC=${CC}' 'LD=${LD}' 'LDFLAGS=${LDFLAGS}' 'CFLAGS=${CFLAGS}'
>>>> +}
>>>> +
>>>> +do_install () {
>>>> +    install -d ${D}${bindir}
>>>> +    install -d ${D}${sbindir}
>>>> +    install -d ${D}${mandir}/man1
>>>> +    install -d ${D}${mandir}/man8
>>>> +    install -d ${D}${sysconfdir}/xinetd.d
>>>> +
>>>> +    sed -i 's/install -s/install/' tftp/Makefile
>>>> +    sed -i 's/install -s/install/' tftpd/Makefile
>>>> +
>>>> +    oe_runmake 'INSTALLROOT=${D}' 'BINMODE=0755' \
>>>> +    'DAEMONMODE=0755' 'MANMODE=0644' \
>>>> +    'BINDIR=${bindir}' 'SBINDIR=${sbindir}' \
>>>> +    'MANDIR=${mandir}' install
>>>> +
>>>> +    install ${WORKDIR}/tftp.conf ${D}/${sysconfdir}/xinetd.d/tftp
>>>> +}
>>>> +
>>>> +PACKAGES = "${PN}-client ${PN}-server ${PN}-doc ${BPN}-dbg"
>>>> +FILES_${PN}-client = "${bindir}/*"
>>>> +FILES_${PN}-server = "${sbindir}/* ${sysconfdir}/xinetd.d/*"
>>>> +FILES_${PN}-doc = "${mandir}"
>>>> +FILES_${PN}-dbg = "${prefix}/src/debug \
>>>> +            ${bindir}/.debug ${sbindir}/.debug"
>>>> +
>>>> +RDEPENDS_${PN}-server = "tcp-wrappers xinetd"
>>>> --
>>>> 1.9.1
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>>
>>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>