Re: [meta-networking][PATCH 1/2] proftpd: fix rdepends issue

[akuster808 <akuster808@gmail.com>]

On 01/06/2015 08:26 AM, Martin Jansa wrote:
> On Tue, Jan 06, 2015 at 07:59:19AM -0800, Armin Kuster wrote:
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>>   meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
>> index cba39e8..7d285a0 100644
>> --- a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
>> +++ b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
>> @@ -99,4 +99,4 @@ USERADD_PARAM_${PN} = "--system -g ${FTPGROUP} --home-dir /var/lib/${FTPUSER} --
>>
>>   FILES_${PN} += "/home/${FTPUSER}"
>>
>> -RDEPENDS_${PN} += "perl"
>> +RDEPENDS_${PN} += "perl initscripts-functions"
>
> It's not that simple.

Had to try :)
>
> The initscripts-functions is added to RDEPENDS conditionally based on
> "sysvinit" in DISTRO_FEATURES and INHIBIT_UPDATERCD_BBCLASS.
>
> Adding it explicitly here will pull it to image even for people who
> care only about systemd services (and don't want any iniscripts to
> pollute their startup sequence).

make sense.

>
> See meta/classes/update-rc.d.bbclass

thanks for the reference.
>
> I know we already have one recipe like this:
> meta-oe/recipes-connectivity/krb5/krb5_1.12.2.bb:RDEPENDS_${PN} += "initscripts-functions"
>
> but honestly silencing this warning like this does more harm then
> the warning. I think it should be fixed in bbclass, because all
> recipes which inherit it, suffer from this. Maybe by adding another
> VIRTUAL_RUNTIME which can be set to empty when sysv isn't enabled.

k.

Does the 5 second rule count ? or because I touched it I am stuck with 
it ; )

I will take a look.

thanks,
Armin
>
>
>