Re: [meta-oe][PATCH] vim: add checksum

["Rafaël Carré" <funman@videolan.org>]

On 03/22/2015 04:55 PM, Martin Jansa wrote:
> On Sun, Mar 22, 2015 at 11:09:03AM +0100, Rafaël Carré wrote:
>> Hello,
>>
>> I couldn't reproduce the checksum error with a fresh build with an empty
>> downloads/ folder.
>>
>> So this patch is apparently needed only when populating downloads/
>> folder before fetching vim.
>>
>> I will investigate a bit more, I think the patch should actually be in
>> bitbake
>> (missing supports_checksum for Hg.py)
> 
> Should bitbake support checksums for hg? We don't use them for any other
> SCM like git or svn, if we do that for hg, what will be included in th
> checksum? Whole directory with hg checkout? Is it stable (e.g. doesn't
> hg fetch everything and then checkout required revision like git does?)

Exactly, what I meant was Hg.py needs to explicitely say checksums are
disabled:

supports_checksum(foo):
    return False


> I've included this patch in master-next, but now when I see that it's
> fetched from hg I'll drop it.
> 
>> On 03/20/2015 03:20 PM, Rafaël Carré wrote:
>>> ---
>>>  meta-oe/recipes-support/vim/vim_7.4.481.bb | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/meta-oe/recipes-support/vim/vim_7.4.481.bb b/meta-oe/recipes-support/vim/vim_7.4.481.bb
>>> index afdea84..ac59077 100644
>>> --- a/meta-oe/recipes-support/vim/vim_7.4.481.bb
>>> +++ b/meta-oe/recipes-support/vim/vim_7.4.481.bb
>>> @@ -10,6 +10,10 @@ SRC_URI = "hg://vim.googlecode.com/hg/;protocol=https;module=vim \
>>>             file://disable_acl_header_check.patch;patchdir=.. \
>>>             file://vim-add-knob-whether-elf.h-are-checked.patch;patchdir=.. \
>>>  "
>>> +
>>> +SRC_URI[md5sum] = "5fd5d754581a673a25733c12367cf9d2"
>>> +SRC_URI[sha256sum] = "e2cc416dabea503e9e5631afc21bb00dcbfb9d05481641b75f247fd89ff4d7e8"
>>> +
>>>  SRCREV = "v7-4-481"
>>>  
>>>  S = "${WORKDIR}/vim/src"