Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: openembedded-devel@lists.openembedded.org
Cc: "[meta-raspberrypi] yocto"@yoctoproject.org
Subject: Re: [meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good.
Date: Fri, 22 May 2015 05:23:29 -0600	[thread overview]
Message-ID: <555F11B1.4060600@mlbassoc.com> (raw)
In-Reply-To: <1432289074-1358-1-git-send-email-thomas.perrot@tupi.fr>

On 2015-05-22 04:04, Thomas Perrot wrote:
> Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
> ---
>   conf/machine/include/rpi-base.inc |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/conf/machine/include/rpi-base.inc b/conf/machine/include/rpi-base.inc
> index a26803a..1dda207 100644
> --- a/conf/machine/include/rpi-base.inc
> +++ b/conf/machine/include/rpi-base.inc
> @@ -7,7 +7,7 @@ include conf/machine/include/soc-family.inc
>
>   IMAGE_FSTYPES ?= "tar.bz2 ext3 rpi-sdimg"
>
> -SERIAL_CONSOLE ?= "115200 ttyAMA0"
> +SERIAL_CONSOLE = "115200 ttyAMA0"
>
>   XSERVER = " \
>       xserver-xorg \
>

Firstly, this should go to the RaspberryPi list (CC'd), not here.

How can this value, which is only ever defined in this file
when using MACHINE=raspberrypi* be affected by another layer?
Is there is another layer which is defining this variable
outside of the MACHINE .conf files, then that layer is incorrect,
not this one.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


  reply	other threads:[~2015-05-22 11:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 10:04 [meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good Thomas Perrot
2015-05-22 11:23 ` Gary Thomas [this message]
2015-05-22 12:49   ` Thomas PERROT
2015-05-22 13:01     ` Gary Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555F11B1.4060600@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc="[meta-raspberrypi] yocto"@yoctoproject.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox