From: Robert Yang <liezhi.yang@windriver.com>
To: <openembedded-devel@lists.openembedded.org>,
<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] fetch/hg: Disable checksums for archived downloads
Date: Fri, 29 May 2015 09:49:37 +0800 [thread overview]
Message-ID: <5567C5B1.7010901@windriver.com> (raw)
In-Reply-To: <1432309170-5575-1-git-send-email-ashcharles@gmail.com>
Hello,
I think that the following patch has broken the mirror tarball of hg:
http://lists.openembedded.org/pipermail/bitbake-devel/2015-May/005725.html
I wonder how did you test the patch, please ? Did you revert the patch:
fetch/hg: support submodules ?
Or other ways, please ?
// Robert
On 05/22/2015 11:39 PM, Ash Charles wrote:
> Like the Git fetcher, the Mercurial fetcher shouldn't expect recipes to
> provide a checksum. As described [1], recipes using a mercurial
> fetcher that don't provide a checksum will fail in a the repository has
> previously been downloaded and archived.
>
> Credit to Rafaël Carré for figuring out the bug.
>
> [1] https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg41328.html
>
> Signed-off-by: Ash Charles <ashcharles@gmail.com>
> ---
> bitbake/lib/bb/fetch2/hg.py | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/bitbake/lib/bb/fetch2/hg.py b/bitbake/lib/bb/fetch2/hg.py
> index 81592f6..cab371f 100644
> --- a/bitbake/lib/bb/fetch2/hg.py
> +++ b/bitbake/lib/bb/fetch2/hg.py
> @@ -43,6 +43,13 @@ class Hg(FetchMethod):
> """
> return ud.type in ['hg']
>
> + def supports_checksum(self, urldata):
> + """
> + Don't require checksums for local archives created from
> + repository checkouts.
> + """
> + return False
> +
> def urldata_init(self, ud, d):
> """
> init hg specific variable within url data
>
next prev parent reply other threads:[~2015-05-29 1:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 14:20 [meta-oe][PATCH] vim: add checksum Rafaël Carré
2015-03-22 10:09 ` Rafaël Carré
2015-03-22 15:55 ` Martin Jansa
2015-03-22 17:23 ` Rafaël Carré
2015-04-27 10:51 ` Martin Jansa
2015-05-22 15:39 ` [PATCH] fetch/hg: Disable checksums for archived downloads Ash Charles
2015-05-29 1:49 ` Robert Yang [this message]
2015-05-29 5:46 ` [bitbake-devel] " Ash Charles
2015-05-29 9:18 ` Martin Jansa
2015-06-02 0:08 ` Ash Charles
2015-06-02 4:38 ` Robert Yang
2015-08-06 10:54 ` Steffen Sledz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5567C5B1.7010901@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox