Re: [meta-qt5][PATCH] libconnman-qt5: new recipe

[Jonathan Liu <net147@gmail.com>]

Hi,

On 1/07/2015 11:19 PM, Martin Jansa wrote:
> On Wed, Jul 01, 2015 at 11:44:40AM +0200, Andreas Oberritter wrote:
>> Hello Jonathan,
>>
>> On 01.07.2015 11:05, Jonathan Liu wrote:
>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>> ---
>>>   recipes-qt/libconnman-qt/libconnman-qt5_git.bb | 17 +++++++++++++++++
>>>   1 file changed, 17 insertions(+)
>>>   create mode 100644 recipes-qt/libconnman-qt/libconnman-qt5_git.bb
>>>
>>> diff --git a/recipes-qt/libconnman-qt/libconnman-qt5_git.bb b/recipes-qt/libconnman-qt/libconnman-qt5_git.bb
>>> new file mode 100644
>>> index 0000000..0ca57e2
>>> --- /dev/null
>>> +++ b/recipes-qt/libconnman-qt/libconnman-qt5_git.bb
>>> @@ -0,0 +1,17 @@
>>> +require recipes-qt/qt5/qt5.inc
>>> +
>>> +SUMMARY = "Qt Library for ConnMan"
>>> +HOMEPAGE = "https://github.com/nemomobile/libconnman-qt"
>>> +LICENSE = "Apache-2.0"
>>> +LIC_FILES_CHKSUM = "file://libconnman-qt/clockmodel.h;endline=8;md5=ea9f724050803f15d2d900ce3c5dac88"
>>> +DEPENDS += "qtbase qtdeclarative"
>>> +PV = "1.0.89+git${SRCPV}"
>>> +
>>> +SRCREV = "79a8d10479ba55951ffa375a66797eedff230dd3"
>>> +SRC_URI = "git://github.com/nemomobile/libconnman-qt.git"
>>> +
>>> +S = "${WORKDIR}/git"
>>> +
>>> +inherit pkgconfig
>>> +
>>> +RDEPENDS_${PN} += "connman"
>> I have a slightly different version in my meta-qt5 repo (fido):
>>
>> https://github.com/opendreambox/meta-qt5/commit/9e616b42e266f1c804daae1eb5dcf693c0f07b42
>>
>> Can you please compare both versions and make sure that the things you
>> omitted aren't needed anymore? Note that libconnman-qt.inc is equal to
>> the version in meta-openembedded.
> Another recipe to the party :)
> https://github.com/webOS-ports/meta-webos-ports/blob/master/meta-luneos/recipes-connectivity/connman/libconnman-qt_git.bb
>
> Yes, it would be nice to consolidate all 3 in one which suits us all.
>
>
>
I initially had a recipe similar to the one in opendreambox with the 
.pro variable hacks but it required libconnman-qt.inc from 
meta-openembedded. I wanted to remove the meta-openembedded dependency 
so I refactored it. In the process I tested without the hacks and I 
reused the logic from qt5.inc to reduce duplication.

I have successfully tested building the recipe with an application that 
depends on libconnman-qt5 using both the C++ and QML bindings and using 
it on the target device.

Regards,
Jonathan