Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Jonathan Liu <net147@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-qt5][PATCH v2 04/11] qt5: add host paths to qt.conf
Date: Sun, 30 Aug 2015 22:30:13 +1000	[thread overview]
Message-ID: <55E2F755.5030003@gmail.com> (raw)
In-Reply-To: <63bae5e8f510c228002db87998ad031708fc69dd.1440502860.git.samuli.piippo@theqtcompany.com>

On 25/08/2015 9:43 PM, Samuli Piippo wrote:
> Add missing HostData and HostLibraries paths to qt.conf for qmake.
> Using the target sysroot for the HostData, allows us to remove the
> symbolic link for the mkspecs.
>
> Signed-off-by: Samuli Piippo <samuli.piippo@theqtcompany.com>
> ---
>   classes/populate_sdk_qt5.bbclass | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/classes/populate_sdk_qt5.bbclass b/classes/populate_sdk_qt5.bbclass
> index d29ec36..3f33b23 100644
> --- a/classes/populate_sdk_qt5.bbclass
> +++ b/classes/populate_sdk_qt5.bbclass
> @@ -4,10 +4,6 @@
>   inherit qmake5_paths
>   
>   create_sdk_files_prepend () {
> -    # make a symbolic link to mkspecs for compatibility with QTCreator
> -    (cd ${SDK_OUTPUT}/${SDKPATHNATIVE}; \
> -         ln -sf ${SDKTARGETSYSROOT}${libdir}/${QT_DIR_NAME}/mkspecs mkspecs;)
> -
>       # Generate a qt.conf file to be deployed with the SDK
>       qtconf=${SDK_OUTPUT}/${SDKPATHNATIVE}${OE_QMAKE_PATH_HOST_BINS}/qt.conf
>       touch $qtconf
> @@ -28,5 +24,7 @@ create_sdk_files_prepend () {
>       echo 'Examples = ${SDKTARGETSYSROOT}${OE_QMAKE_PATH_QT_EXAMPLES}' >> $qtconf
>       echo 'Tests = ${SDKTARGETSYSROOT}${OE_QMAKE_PATH_QT_TESTS}' >> $qtconf
>       echo 'HostPrefix = ${SDKPATHNATIVE}' >> $qtconf
> +    echo 'HostData = ${SDKTARGETSYSROOT}${OE_QMAKE_PATH_QT_ARCHDATA}' >> $qtconf
>       echo 'HostBinaries = ${SDKPATHNATIVE}${OE_QMAKE_PATH_HOST_BINS}' >> $qtconf
> +    echo 'HostLibraries = ${SDKPATHNATIVE}${OE_QMAKE_PATH_LIBS}' >> $qtconf
>   }
This works but is it logically correct to use a directory that contains 
binaries compiled for the target as the host data directory...?
The mkspecs are architecture independent but the plugins are target 
specific.

Regards,
Jonathan


  reply	other threads:[~2015-08-30 12:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 11:43 [meta-qt5][PATCH v2 00/11] upstreaming Qt for Device Creation changes Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 01/11] qt5: make populate_sdk_qt5 reusable Samuli Piippo
2015-08-30 12:49   ` Jonathan Liu
2015-09-01 13:21     ` Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 02/11] qt5: improve Qt module package handling Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 03/11] qt5: improve support for native and nativesdk modules Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 04/11] qt5: add host paths to qt.conf Samuli Piippo
2015-08-30 12:30   ` Jonathan Liu [this message]
2015-09-01 13:07     ` Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 05/11] qt5: disable debian auto renaming Samuli Piippo
2015-09-02 17:07   ` Otavio Salvador
2015-09-02 17:25     ` Martin Jansa
2015-09-02 17:53       ` Otavio Salvador
2015-09-03 13:10         ` Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 06/11] qt5: make qt5.inc reusable qt5-module.bbclass Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 07/11] qttools: use one recipe for all compilations Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 08/11] qtbase: remove dependency to sqlite Samuli Piippo
2015-09-02 17:08   ` Otavio Salvador
2015-08-25 11:43 ` [meta-qt5][PATCH v2 09/11] qtbase: PACKAGECONFIGs for libproxy and libinput Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 10/11] qtlocation: use correct dependencies Samuli Piippo
2015-08-25 11:43 ` [meta-qt5][PATCH v2 11/11] qtwebengine: fix problem with recursive qmake call Samuli Piippo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E2F755.5030003@gmail.com \
    --to=net147@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox